Skip to content

Commit

Permalink
Merge pull request #207 from moturoa/master
Browse files Browse the repository at this point in the history
id not required for tabBox + text align fix menuItems
  • Loading branch information
DivadNojnarg authored May 26, 2021
2 parents d0ab5b8 + 3be4100 commit eae7be5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion R/cards.R
Original file line number Diff line number Diff line change
Expand Up @@ -1110,7 +1110,7 @@ bs4InfoBox <- function(title, value = NULL, subtitle = NULL, icon = shiny::icon(
#' @author David Granjon, \email{dgranjon@@ymail.com}
#'
#' @export
bs4TabCard <- function(..., id, selected = NULL, title = NULL, width = 6,
bs4TabCard <- function(..., id = NULL, selected = NULL, title = NULL, width = 6,
height = NULL, side = c("left", "right"), type = NULL,
footer = NULL, status = NULL, solidHeader = FALSE, background = NULL,
collapsible = TRUE, collapsed = FALSE, closable = FALSE, maximizable = FALSE,
Expand Down
2 changes: 1 addition & 1 deletion R/dashboardSidebar.R
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ bs4SidebarMenuItem <- function(text, ..., icon = NULL, badgeLabel = NULL, badgeC

if (!is.null(icon)) {
tagAssert(icon, type = "i")
icon$attribs$cl <- paste0(icon$attribs$cl, " nav-icon")
icon$attribs$class <- paste0(icon$attribs$class, " nav-icon")
}

if (!is.null(href) + !is.null(tabName) + (length(subItems) > 0) != 1) {
Expand Down

0 comments on commit eae7be5

Please sign in to comment.