Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix! fix bip137 sig #578

Merged
merged 4 commits into from
Apr 28, 2024
Merged

bugfix! fix bip137 sig #578

merged 4 commits into from
Apr 28, 2024

Conversation

RyanKung
Copy link
Member

@RyanKung RyanKung commented Apr 28, 2024

Fixed: recovery ID of compressed bitcoin signature is not covered in our implementation.

Protocol Details:

y-parity x-order compression recovery id v
even less than n false 0 27
odd less than n false 1 28
even more than n false 2 29
odd more than n false 3 30
even less than n true 0 31
odd less than n true 1 32
even more than n true 2 33
odd more than n true 3 34

@RyanKung RyanKung merged commit e85f00f into master Apr 28, 2024
5 checks passed
@RyanKung RyanKung deleted the bugfix_fix_bip137_sig branch April 28, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant