feat!: differentiate swarms based on network_id #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ma233
commented
Apr 25, 2024
| @@ -60,6 +60,10 @@ impl HandleMsg<QueryForTopoInfoReport> for MessageHandler { | |||
| #[cfg_attr(not(feature = "wasm"), async_trait)] | |||
| impl HandleMsg<ConnectNodeSend> for MessageHandler { | |||
| async fn handle(&self, ctx: &MessagePayload, msg: &ConnectNodeSend) -> Result<()> { | |||
| if msg.network_id != self.transport.network_id { | |||
| return Ok(()); | |||
There was a problem hiding this comment.
Should the current node directly not respond when receiving a handshake request from a different network node?
There was a problem hiding this comment.
Yes, response of denial of connection may be expensive in some case, especially the signature/verify phase.
Ma233
force-pushed
the
transport
branch
3 times, most recently
from
6c3c6f0
to
28134f8
Compare
|
@RyanKung Hi, it's a breaking change in config file. We may should upgrade the minor version number. |
RyanKung
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
🔵 What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR introduces a
network_idfield inConnectNodeSendmessage. It's used to prevent nodes from different networks from connecting to each other.🟤 What is the current behavior? (You can also link to an open issue here)
🟢 What is the new behavior (if this is a feature change)?
☢️ Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
There is a breaking change in config file.
User must specify network_id in config file now.
ℹ️ Other information
Closes #issue