Added kinetics to the HTML output from RMG-Py #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HTML page also has the ability to toggle display of these details. The separation between formatting and function has been slightly blurred by this approach (putting a toHTML() method in the actual class definition) but I think it offers the most flexibility, at least until we can think of a "better" way.
…ts html. The results file in HTML format requires jquery for some of the display toggling. This commit allows you to view results without an internet connection.
In some cases I think this is an improvement; in others perhaps not. Not very important anyway.
This means that if you have a file or folder with the same name as one of these, the target is run even if the file/folder is up to date.
I forgot these when I added the methods. Hope this is correct.
|
Looks good. I don't see any comments yet on the minimal example, presumably because there aren't any (yet) from the group additivity values. We'll have to figure out a good way to comment those sometime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a start, anyway. Josh, if it looks OK to you do you want to pull it in?