Fix simdat_crossed for between-subject/between-item factors

[jschepers]

Hello,

I noticed a bug in the simdat_crossed function for factors that are both between-subject and between-items.

Example:

data = DataFrame(MixedModelsSim.simdat_crossed(2,4; subj_btwn = Dict(:cond => ["levelA","levelB"]), item_btwn = Dict(:cond => ["levelA","levelB"])))

For this function call, I would expect a design in which every subject (and every item) is only in one condition i.e. levelA or levelB.
However, one gets the following result:

@behinger and I adapted the simdat_crossed function for cases with between-subject/between-item factors and added new tests.

[behinger]

bump @palday, maybe you can have a look if you have time

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fe3b36a) 95.49% compared to head (5ccbeb2) 95.76%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   95.49%   95.76%   +0.26%     
==========================================
  Files           4        4              
  Lines         111      118       +7     
==========================================
+ Hits          106      113       +7     
  Misses          5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[palday]

some formatting and efficiency suggestions, but overall looks good. Can you also bump the version in Project.toml to 0.2.8?

[jschepers]

some formatting and efficiency suggestions, but overall looks good. Can you also bump the version in Project.toml to 0.2.8?

Thank you for the useful suggestions, especially regarding efficiency. I committed all the suggestions.
It looks like the version was already bumped to 0.2.8. (080910f) but there has been no new release since then.

[palday]

CI failure is unrelated and I can't reproduce locally, so LGTM!