Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide some backwards compatibility with existing binaries #233

Merged
merged 7 commits into from
Jan 18, 2025

Conversation

kevinushey
Copy link
Contributor

Mainly to avoid breakage on CRAN, and to allow existing package binaries to continue to work. (At least, some subset of them.)

@kevinushey kevinushey merged commit c276b03 into master Jan 18, 2025
3 checks passed
@MaxAtoms
Copy link

MaxAtoms commented Feb 8, 2025

Thank you! The missing binary compatibility broke our pipeline because we explicitly requested 5.1.9, but the package lamW was built against 5.1.10 on the Posit Public Package Manager:
https://forum.posit.co/t/discrepancy-between-snapshots/197445. Glad to see that this should not happen in the future

Edit: Looking over the changelog, I am actually not sure whether this PR is related and would have helped

@kevinushey
Copy link
Contributor Author

Yeah, that's right -- this PR is actually probably responsible for the breakage you saw. In particular, packages built against RcppParallel 5.1.10 won't work if RcppParallel 5.1.9 is currently installed.

This change was ultimately requested by CRAN, and is necessary to provide RcppParallel a pathway to updating the bundled version of TBB without breaking all existing CRAN binary packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants