Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.11 #250

Merged
merged 19 commits into from
Sep 16, 2023
Merged

v0.11 #250

merged 19 commits into from
Sep 16, 2023

Conversation

Raffaello
Copy link
Owner

@Raffaello Raffaello commented Sep 11, 2023

  • OPL2instrument_t looks not includable for client of the lib. because .h file are not included in the install cmake part
  • mixer master volume setting is missing.
  • sdl audio driver option is missing, it's just using automatically, but there could be more then one it looks (it must be set before calling SDL_Init, quite annoying, also a small test with "directsound" drivers only NukedOPL was working, not worth doing it at the moment.)
  • reverseStereo flag not everywhere available, it should be a mixer flag
  • opl emulated using groupchannel is hardcoded to plain, it requires to choose which one is. So creating multiple opl operator can be dedicated to sfx and music
  • Unifying&Reviewing opl drivers, devices and OPLs #249
  • midi:devices move to devices that embedd the MIDDriver and ADLDriver for now and have a overloadede play method to play from the device, simpler to use.

@Raffaello Raffaello self-assigned this Sep 11, 2023
@Raffaello Raffaello changed the title init v0.11 Sep 11, 2023
@Raffaello Raffaello added bug Something isn't working enhancement New feature or request driver driver related device wrapper around drivers and hardware to represent a sound card labels Sep 11, 2023
@Raffaello Raffaello added this to the AdLib / SoundBlaster Pro milestone Sep 11, 2023
@Raffaello Raffaello linked an issue Sep 11, 2023 that may be closed by this pull request
@sonarcloud
Copy link

sonarcloud bot commented Sep 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 68 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Raffaello Raffaello merged commit c4b0eae into master Sep 16, 2023
8 checks passed
@Raffaello Raffaello deleted the v0.11 branch September 16, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working device wrapper around drivers and hardware to represent a sound card driver driver related enhancement New feature or request
Projects
Status: Done
Status: Done
Status: Done
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant