Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifying&Reviewing opl drivers, devices and OPLs #249

Open
Raffaello opened this issue Sep 11, 2023 · 0 comments
Open

Unifying&Reviewing opl drivers, devices and OPLs #249

Raffaello opened this issue Sep 11, 2023 · 0 comments
Assignees
Labels
driver driver related refactor refactoring code, same functionality, but better code

Comments

@Raffaello
Copy link
Owner

Raffaello commented Sep 11, 2023

  • MIDDriver is using midi::devices namespace

  • ADLDriver is using a bare OPL device, must be converted to use midi::devices

  • midi::devices requires an OP2Bank, it might not be available. so it must be optional. or create a parallel adl::devices ...
    also must check if those shared_ptr are not nullptrs ....

  • ADLDriver is also taking in an ADLFile, while all the other are taking in a MIDI parsed file., but it can be ok in this case. ADL file and driver are very specific and not intended to be a standard like MIDI.


midi:devices move to devices that embedd the MIDDriver and ADLDriver for now and have a overloadede play method to play from the device, simpler to use.

@Raffaello Raffaello added the driver driver related label Sep 11, 2023
@Raffaello Raffaello self-assigned this Sep 11, 2023
@Raffaello Raffaello mentioned this issue Sep 11, 2023
7 tasks
@Raffaello Raffaello linked a pull request Sep 11, 2023 that will close this issue
7 tasks
@Raffaello Raffaello added the refactor refactoring code, same functionality, but better code label Sep 16, 2023
@Raffaello Raffaello removed a link to a pull request Sep 16, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
driver driver related refactor refactoring code, same functionality, but better code
Projects
Status: To do
Status: To do
Status: To do
Development

No branches or pull requests

1 participant