Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bsp][airm2m/air105][rsoc] Fix compilation issues with bsp of airm2m/air105 #9489

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hydevcode
Copy link
Contributor

@hydevcode hydevcode commented Sep 29, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

发现airm2m/air105在编译最后一步会出错

你的解决方案是什么 (what is your solution)

修改makesoc.py

请提供验证的bsp和config (provide the config and bsp)

  • BSP:bsp/airm2m/air105
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@github-actions github-actions bot added BSP action github action yml imporve labels Sep 29, 2024
@mysterywolf
Copy link
Member

@Dozingfiretruck 帮忙review一下这个PR呗

@@ -53,10 +54,11 @@ void rt_hw_board_init(void)
#ifdef RT_USING_HEAP
rt_system_heap_init((void *)HEAP_BEGIN, (void *)HEAP_END);
#endif
extern void rt_hw_systick_init(void);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个函数的头文件在哪里呀 可否直接引用头文件呀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已手动声明函数在对应的头文件,修改好了


shutil.copy(out_path+bin_file_name, pack_path+'/'+bin_file_name)
shutil.make_archive(out_file, 'zip', root_dir=pack_path)
os.remove(pack_path+'/'+bin_file_name)
os.rename(out_file+'.zip',out_file+'.soc')
print('end')
print('end')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多敲一个换行

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

@hydevcode hydevcode marked this pull request as draft September 30, 2024 02:56
…air105

Update bsp/airm2m/air105/libraries/HAL_Driver/Src/core_dma.c

Co-authored-by: Meco Man <[email protected]>

[bsp][airm2m/air105][rsoc] Fix compilation issues with bsp of airm2m/air105
@hydevcode hydevcode marked this pull request as ready for review September 30, 2024 05:42
@Dozingfiretruck
Copy link
Contributor

因为会网络下载bl所以ci 是否添加评估一下
另外 合宙已经放弃mcu业务,此bsp是否删除也请评估下
@mysterywolf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action github action yml imporve BSP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants