-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libcpu][aarch64] 使用设备树对CPU进行初始化 #8221
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是否可以把整体关系先理清?关系不清,最终是越来越乱……
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
一些代码能不修改的,尽可能不修改。特别是涉及到其他无关的代码部分
bsp/phytium/board/board.c
Outdated
@@ -29,7 +29,6 @@ | |||
|
|||
#include <gicv3.h> | |||
#if defined(TARGET_ARMV8_AARCH64) | |||
#include <psci.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
phytium bsp这两个地方是必须需要修改的吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个bsp使用的是自己实现的psci,已经#include <fpsci.h>,不会用到libcpu/aarch64/里面的psci,所以将这个#include <psci.h>删去 @BernardXiong
This reverts commit 249871c.
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
你的解决方案是什么 (what is your solution)
在什么测试环境下测试通过 (what is the test environment)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up