Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libcpu][aarch64] 使用设备树对CPU进行初始化 #8221

Merged
merged 11 commits into from
Nov 28, 2023

Conversation

fangjianzhou
Copy link
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

  • 使用设备树对CPU进行初始化,并修复qemu-virt64-aarch64多核无法启动的问题

你的解决方案是什么 (what is your solution)

  • 重构libcpu/aarch64CPU部分的代码,将RT_USING_FDT接口的代码改为RT_USING_OFW的

在什么测试环境下测试通过 (what is the test environment)

  • 在使用时需要开启 RT_USING_DM,RT_USING_OFW,RT_USING_FIRMWARE,RT_FIRMWARE_PSCI
  • 在qemu-virt64-aarch64中测试通过

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

bsp/qemu-virt64-aarch64/rtconfig.h Outdated Show resolved Hide resolved
bsp/rockchip/rk3568/rtconfig.h Outdated Show resolved Hide resolved
components/drivers/firmware/Kconfig Outdated Show resolved Hide resolved
components/drivers/ofw/base.c Outdated Show resolved Hide resolved
components/drivers/ofw/fdt.c Outdated Show resolved Hide resolved
libcpu/aarch64/common/cpuport.h Outdated Show resolved Hide resolved
libcpu/aarch64/common/cpu.c Outdated Show resolved Hide resolved
libcpu/aarch64/common/cpu.c Outdated Show resolved Hide resolved
Copy link
Member

@BernardXiong BernardXiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是否可以把整体关系先理清?关系不清,最终是越来越乱……

components/drivers/include/drivers/pm.h Outdated Show resolved Hide resolved
components/drivers/include/drivers/psci.h Outdated Show resolved Hide resolved
Copy link
Member

@BernardXiong BernardXiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一些代码能不修改的,尽可能不修改。特别是涉及到其他无关的代码部分

@@ -29,7 +29,6 @@

#include <gicv3.h>
#if defined(TARGET_ARMV8_AARCH64)
#include <psci.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phytium bsp这两个地方是必须需要修改的吗?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个bsp使用的是自己实现的psci,已经#include <fpsci.h>,不会用到libcpu/aarch64/里面的psci,所以将这个#include <psci.h>删去 @BernardXiong

@BernardXiong BernardXiong merged commit 249871c into RT-Thread:master Nov 28, 2023
35 of 39 checks passed
fangjianzhou pushed a commit to fangjianzhou/rt-thread that referenced this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants