Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libcpu][aarch64]fix gicv3 mpidr table #9284

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zmshahaha
Copy link
Contributor

@zmshahaha zmshahaha commented Aug 7, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

#8221 去掉了非设备树初始化CPU的方法,设备树初始化CPU的框架下由mpdir_table来存放cpu信息,所以非设备树版gicv3需要使用该变量,同时arm64芯片cpu初始化均应使用设备树(调用rt_hw_common_setup)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

Copy link
Contributor

@polarvid polarvid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arm64 的 CI 有 BSP 不能通过。

最好能在这个 PR 补充一个多核 IPI 的测试用例(简单的注册,发送到其它每个核,设置标志位,检查)。可以是在复用调度器的 IPI。在回调加一个 hook,测试的时候注册进去。hook 中检查是否真正进入了 IPI handler。当然,仅仅是一个建议。

@zmshahaha
Copy link
Contributor Author

@messigogogo 这个phytium芯片的mpdir_table初始化需要重新适配下

@polarvid polarvid added Arch: ARM/AArch64 BSP related with arm bug This PR/issue is a bug in the current code. labels Aug 12, 2024
@messigogogo
Copy link
Contributor

messigogogo commented Aug 15, 2024

@messigogogo 这个phytium芯片的mpdir_table初始化需要重新适配下

这个pr暂时只修改rt_cpu_mpidr_early -> rt_cpu_mpidr_table名称吗?后续修改还在准备提交吗?@zmshahaha

@zmshahaha
Copy link
Contributor Author

@messigogogo 这个phytium芯片的mpdir_table初始化需要重新适配下

这个pr暂时只修改rt_cpu_mpidr_early -> rt_cpu_mpidr_table名称吗?后续修改还在准备提交吗?@zmshahaha

是的,因为pr #8221 将rt_cpu_mpidr_early更换为rt_cpu_mpidr_table,gicv3也需要改成这个,这个pr主要是修复错误,没有后续修改。然后phytium需要按之前设置rt_cpu_mpidr_early的方式设置rt_cpu_mpidr_table

@messigogogo
Copy link
Contributor

@messigogogo 这个phytium芯片的mpdir_table初始化需要重新适配下

这个pr暂时只修改rt_cpu_mpidr_early -> rt_cpu_mpidr_table名称吗?后续修改还在准备提交吗?@zmshahaha

是的,因为pr #8221 将rt_cpu_mpidr_early更换为rt_cpu_mpidr_table,gicv3也需要改成这个,这个pr主要是修复错误,没有后续修改。然后phytium需要按之前设置rt_cpu_mpidr_early的方式设置rt_cpu_mpidr_table

好的,如果你要一起修改过ci工具的话,可以把rt-thread/bsp/phytium/board/secondary_cpu.c中的rt_cpu_mpidr_early 改为rt_cpu_mpidr_table,把board.c中的rt_cpu_mpidr_table申明去除。我拉你的代码试了一下,暂时没有问题

@mysterywolf mysterywolf closed this Sep 4, 2024
@mysterywolf mysterywolf reopened this Sep 4, 2024
@github-actions github-actions bot added BSP libcpu BSP: Phytium BSP related with Phytium labels Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arch: ARM/AArch64 BSP related with arm BSP: Phytium BSP related with Phytium BSP bug This PR/issue is a bug in the current code. libcpu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants