-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libcpu][aarch64]fix gicv3 mpidr table #9284
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arm64 的 CI 有 BSP 不能通过。
最好能在这个 PR 补充一个多核 IPI 的测试用例(简单的注册,发送到其它每个核,设置标志位,检查)。可以是在复用调度器的 IPI。在回调加一个 hook,测试的时候注册进去。hook 中检查是否真正进入了 IPI handler。当然,仅仅是一个建议。
@messigogogo 这个phytium芯片的mpdir_table初始化需要重新适配下 |
这个pr暂时只修改rt_cpu_mpidr_early -> rt_cpu_mpidr_table名称吗?后续修改还在准备提交吗?@zmshahaha |
是的,因为pr #8221 将rt_cpu_mpidr_early更换为rt_cpu_mpidr_table,gicv3也需要改成这个,这个pr主要是修复错误,没有后续修改。然后phytium需要按之前设置rt_cpu_mpidr_early的方式设置rt_cpu_mpidr_table |
好的,如果你要一起修改过ci工具的话,可以把rt-thread/bsp/phytium/board/secondary_cpu.c中的rt_cpu_mpidr_early 改为rt_cpu_mpidr_table,把board.c中的rt_cpu_mpidr_table申明去除。我拉你的代码试了一下,暂时没有问题 |
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
#8221 去掉了非设备树初始化CPU的方法,设备树初始化CPU的框架下由mpdir_table来存放cpu信息,所以非设备树版gicv3需要使用该变量,同时arm64芯片cpu初始化均应使用设备树(调用rt_hw_common_setup)
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up