Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(electron): openElectronWindow #532

Closed
wants to merge 2 commits into from
Closed

perf(electron): openElectronWindow #532

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2059082
perf(electron): openElectronWindow
Simon-He95 Sep 20, 2024
0307422
Merge branch 'dev' into dev
Simon-He95 Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/shared/src/electron.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,19 @@ export interface OpenElectronWindowOptions {
* Work electron and browser,
* if in electron, open a new window, otherwise open a new tab
*/
export const openElectronWindow = (url: string, options: OpenElectronWindowOptions = {}) => {
if ("electron" in window) {
export const openElectronWindow = (() => ("electron" in window)
? ((url: string, options: OpenElectronWindowOptions = {}) => {
const urlObject = new URL(url)
const { searchParams } = urlObject

searchParams.set(ELECTRON_QUERY_KEY, encodeURIComponent(JSON.stringify(options)))

window.open(urlObject.toString())
} else {
})
: ((url: string) => {
// eslint-disable-next-line no-restricted-globals
window.open(url.replace(DEEPLINK_SCHEME, `${location.origin}/`))
}
}
}))()

export const extractElectronWindowOptions = (url: string): OpenElectronWindowOptions => {
try {
Expand Down
Loading