Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(electron): openElectronWindow #532

Closed
wants to merge 2 commits into from
Closed

Conversation

Simon-He95
Copy link
Contributor

Description

Linked Issues

Additional context

Copy link

vercel bot commented Sep 20, 2024

@Simon-He95 is attempting to deploy a commit to the RSS3 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@Innei Innei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

@Simon-He95
Copy link
Contributor Author

There should be no need to judge the current environment every time you execute it. It can be determined when it is loaded for the first time, and then choose to use window or electron.

@Innei
Copy link
Member

Innei commented Sep 20, 2024

Optimizations that do little to enhance, but instead degrade readability and code style

@Innei Innei closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants