Ref implementation of FP8 #2438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfultz2
reviewed
Nov 10, 2023
pfultz2
reviewed
Nov 10, 2023
pfultz2
reviewed
Nov 10, 2023
pfultz2
reviewed
Nov 10, 2023
pfultz2
reviewed
Nov 10, 2023
pfultz2
reviewed
Nov 10, 2023
pfultz2
reviewed
Nov 11, 2023
This build is not recommended to merge 🔴 |
❌agentmodel: ERROR - check error outputTraceback (most recent call last):File "/src/AMDMIGraphX/tools/accuracy/accuracy_checker.py", line 336, in main() File "/src/AMDMIGraphX/tools/accuracy/accuracy_checker.py", line 254, in main pred_migx = np.array(model.run(params)[-1]) RuntimeError: /src/AMDMIGraphX/src/targets/gpu/device/include/migraphx/gpu/device/visit.hpp:140: hip_visit_views_impl: Ranks must be the same 🔴bert_base_cased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output🔴distilgpt2_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
umangyadav
added
the
high priority
pfultz2
reviewed
Nov 15, 2023
Closed
11 tasks
pfultz2
reviewed
Nov 15, 2023
pfultz2
approved these changes
Nov 15, 2023
TedThemistokleous
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
looks good and solid + helpful comments in the code @umangyadav
CharlieL7
reviewed
Nov 15, 2023
| static std::string format() | ||
| { | ||
| // following: https://docs.python.org/3/library/struct.html#format-characters | ||
| return "z"; |
There was a problem hiding this comment.
I don't see "z" in the commented link?
There was a problem hiding this comment.
Yes that is not correct. I am not sure what should be correct format. Between "B", "b", or "c". I'll have to check.
There was a problem hiding this comment.
I've opened an issue: This thing needs to be tested out to see if numpy buffers are created correctly.
#2447
CharlieL7
approved these changes
Nov 16, 2023
pfultz2
reviewed
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handles all 4 Fp8 dtypes listed here : https://onnx.ai/onnx/technical/float8.html
Follows saturation/clipping logic from table there as well : https://onnx.ai/onnx/technical/float8.html#cast
Only adding fp8e4m3fnuz in MIGraphX IR for now.
Other types can be added later if necessary.