Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FP8 Support #1982

Closed
5 of 11 tasks
causten opened this issue Jul 19, 2023 · 3 comments · Fixed by #2438
Closed
5 of 11 tasks

FP8 Support #1982

causten opened this issue Jul 19, 2023 · 3 comments · Fixed by #2438
Assignees
Labels
FP8 issues related to FP8 implemenation

Comments

@causten
Copy link
Collaborator

causten commented Jul 19, 2023

Add ability to quantize to FP8. This will clearly need additional issues to be opened. Flags for the C++/Python API, Test cases, updates to our migraphx-driver, New kernels, a FP8 library , etc.

Success of this first issue should be an itemized list of created issues to support FP8

  • Figure out how to implement FP8 dtype inside MIGraphX.

  • Need more thoughts on this one.

  • Add backend libraries suppport rocblas, ck, miopen, MLIR and HIP Kernels (may need to define hip_fp8).

    • MLIR
    • CK
    • rocBlas
    • MIOpen
    • JIT Kernels
  • Write unit-tests for each of those backends.

  • Update parsing for FP8 models. Need to take into account QAT models with QDQ pairs surrounding convs/gemm only and entire FP8 models.

  • driver needs to support --fp8

  • handle fP32->fp16->fp8 already been quantized model

@krzysz00
Copy link
Contributor

I'll go ahead and comment that MLIR has FP8 * FP8 -> FP32 support, at least for the underlying gemms

@umangyadav
Copy link
Member

umangyadav commented Oct 27, 2023

  • Figure out how to implement FP8 dtype inside MIGraphX.
  • Need more thoughts on this one.
  • Add backend libraries suppport rocblas, ck, miopen, MLIR and HIP Kernels (may need to define hip_fp8).
  • Write unit-tests for each of those backends.
  • Update parsing for FP8 models. Need to take into account QAT models with QDQ pairs surrounding convs/gemm only and entire FP8 models.

@TedThemistokleous TedThemistokleous linked a pull request Nov 15, 2023 that will close this issue
@umangyadav umangyadav reopened this Nov 17, 2023
@umangyadav umangyadav added the FP8 issues related to FP8 implemenation label Dec 1, 2023
@umangyadav
Copy link
Member

Closing this issue as all the tasks are already completed for the FNUZ type. Same kind of tasks are required for the OCP FP8. @CharlieL7 you can open an issue for OCP FP8 following this template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FP8 issues related to FP8 implemenation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants