Add initializers for peripherals based on numbers #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrysn
force-pushed
the
init-by-number
branch
from
0fbf769
to
e587536
Compare
|
Added a test, along with a commit that illustrates how I think board dependent pins are best handled with the number based initializers. (As long as the boards don't provide a more high-level enumeration of user usable peripherals, that is). |
chrysn
force-pushed
the
init-by-number
branch
from
09a80e1
to
2643368
Compare
chrysn
force-pushed
the
init-by-number
branch
from
6501495
to
d52daa9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since RIOT-OS/rust-riot-sys#17 is in, there are riot-sys functions that allow going from device numbers to device types. (That's typically an identity transformation, but we can't know that generally).
This adds a first bout of initializers to wrappers that are based on such numbers.
As a PR, this builds on #34, because practical applications can likely only pull valid input from a match on BOARD (and we really want that const).
ADC is not in because it'll depend on RIOT-OS/rust-riot-sys#34 to do anything sensible.