-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: Rust updates [backport 2024.01] #20384
treewide: Rust updates [backport 2024.01] #20384
Conversation
That auto-backport didn't do what it should have done because GitHub doesn't understand stacked PRs; it should only consist of MrKevinWeiss@002cd42. I don't yet understand why the CI fails, may be related. |
Correction: It should just be the top 4 commits (as we're backporting the full PR). Only the first slid in from #20299 and should not be in unless we backport #20299 too (which is probably a good fix to have but then is more than is necessary to fix the issue at hand). The later commits ("use version 0.3", "use version 1.0", "update to coap-handler" and the "cargo update" due to which we're doing this) don't depend on the 20299 one fundamentally, they just are testable much more easily once that older one is in. |
11d6ea8
to
6068cfb
Compare
I am not quite sure what you wanted, I have just the cargo update. Should I have "use version 0.3", "use version 1.0", "update to coap-handler" and the "cargo update" or should it have been only the 790e808? |
Or is it everything but 790e808... |
Note that for the very CPU this driver is used with (nRF52 on the microbit-v2 board), this currently needs extra workarounds to copy written data from flash to RAM so that the driver can see it. (Otherwise it silently writes 00, and then correctly reads 00 from the bus all the time). (cherry picked from commit 96af920)
(cherry picked from commit 3c5a540)
(cherry picked from commit 6231c58)
(cherry picked from commit 002cd42)
6068cfb
to
4b294e9
Compare
I repushed with my best guess. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, your best guess matches mine.
#20383 needs to be merged first, otherwise the CI will fail |
Backport of #20303
Contribution description
This PR does three things that are easiest done in one go (because due to git dependencies otherwise it would require selective updates):
syn
to pick out constants rust-riot-wrappers#49Testing procedure
aiocoap-client 'coap://[fe80::3c63:beff:fe85:ca96%tapbr0]/vfs/'
Issues/PRs references
Based on #20299