-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export macro_XXX_DEV
macros (I2C_DEV)
#17
Conversation
This makes a build time assertion on the signature being (on the C side) compatible with a single unsigned value. For many types that's a property documented in C tests; for the others, it's conjecture that is aligned with their general perception. Contributes-To: RIOT-OS/rust-riot-wrappers#37
In addition to the CI tests, I'm also running a full buildtest (currently at
(Otherwise, the relevant functions would not be built for lack of macro definitions.) Before doing the bors test when merging the PR that'll pull this in to main RIOT, it may make sense to add a similar alteration there, just to make sure the tests actually cover relevant parts. |
... and it's failing on samd10-xmini, investigating... |
... which it also does without the changes of this commit, so let's see how the larger build test goes. The concrete error I got is:
which has the suspicious "picolibc" in there. Nothing wrong with picolibc probably, but it could be triggering some rarer code paths. I'll try not to lose track of it, but this is several layers of yak fur in. |
OK, full boards survey:
As this PR would only break things build time, that's all I can test. |
19288: rust: Update riot-sys and riot-wrappers r=kaspar030 a=chrysn ### Contribution description rust: Update riot-sys and riot-wrappers * riot-wrappers: * Fix infinite loop when using a Mutex * Make ValueInThread Copy/Clone * riot-sys: * Export xxx_DEV (eg. I2C_DEV) C macros as functions * Add auto_init_utils.h ### Testing procedure CI checks should suffice. ### Issues/PRs references This pulls in fixes from * RIOT-OS/rust-riot-sys#18 * RIOT-OS/rust-riot-sys#17 / RIOT-OS/rust-riot-wrappers#37 * RIOT-OS/rust-riot-wrappers#42 / RIOT-OS/rust-riot-wrappers#41 Co-authored-by: chrysn <[email protected]>
This item was missed because it doesn't follow the XXX_DEV pattern used by other peripherals. See-Also: #17 Contributes-To: RIOT-OS/rust-riot-wrappers#36
ADC_DEV does not exist in RIOT (and thus, no corresponding code was generated for this ever); the macro that goes into adc_init's argument is ADC_LINE. Follow-up-for: #17
This makes a build time assertion on the signature being (on the C side) compatible with a single unsigned value. For many types that's a property documented in C tests; for the others, it's conjecture that is aligned with their general perception.
Contributes-To: RIOT-OS/rust-riot-wrappers#37