-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Netlify server less function to fetch Weather Data #114
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Kushagra Raj Tiwari <[email protected]>
Signed-off-by: Kushagra Raj Tiwari <[email protected]>
Signed-off-by: Kushagra Raj Tiwari <[email protected]>
Signed-off-by: Kushagra Raj Tiwari <[email protected]>
Signed-off-by: Kushagra Raj Tiwari <[email protected]>
@R0Y15 I implemented this serverless function for Netlify. The path where function is stored: ![]() You can check the API response here as well. https://krt-test-deploy-weather-now-delete.netlify.app/.netlify/functions/getWeatherData?city=kolkata Suggestion: Please use Netlify, it is best free platform to deploy static sites. I tried both Github and Netlify, but found Netlify better than Github. It provides good CI/CD integrations than Github. If you want we can connect on video call to discuss the deployment part. Thanks. |
@R0Y15 any update on this PR? |
Hi, sorry for the delay. As per your contribution, we have to switch the whole deployment from GitHub pages to Netlify services, which is not recommended. However, please allow me sometime to further review and take a suitable action. warm regards, |
Yes. You are correct. I understand your concern. But deployment on Netlify is very easy step (2 minutes, only). Also, it provides with continous deployment and integration. I have several projects on Netlify, they are running fine. I also use Netlify for my website as well. https://kurati.dev/ |
Issue
Issue: #108
Changes
netlify/functions/getWeatherData.js
).netlify/functions/.env
). This file is ignored in git..gitignore
file to ignore unnecessary files and directories from git version control.README.md
.Improvement
Future Enhancements [Depends on maintainer's choice]
Netlify function usage
In this PR, Netlify function is used only at one place in code base i.e. to fetch weather data for any city. After merge of this PR, Netlify function can be used to fetch other weather related data. This is intentionally done to keep this PR simple.
Netlify function demo deployment
The code base with Netlify function is deployed on Netlify.
Demo URL: https://krt-test-deploy-weather-now-delete.netlify.app/
Demo Image

Steps for Netlify Deployment
After this PR gets merged follow these steps to deploy site on Netlify.
Import an existing project
.Github
as git provider.WeatherNow
repository.main
.main
branch, Netlify will trigger deploy automatically.