Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Netlify functions to hide API key from Network call #108

Open
krtEngineer opened this issue Oct 17, 2024 · 3 comments
Open

Adding Netlify functions to hide API key from Network call #108

krtEngineer opened this issue Oct 17, 2024 · 3 comments
Assignees

Comments

@krtEngineer
Copy link

krtEngineer commented Oct 17, 2024

@R0Y15 I observed that API key for open weather map api is visible in network call.
I am suggesting an enhancement to hide this API key using netlify serverless functions.

image

I would request to assign this issue to me. I already implemented such functions. Here is a blog on my web site on how to implement such functions: https://kurati.dev/tils/02_netlify_serverless_functions_demo

@R0Y15
Copy link
Owner

R0Y15 commented Oct 18, 2024

Sure, please Go ahead.

@krtEngineer
Copy link
Author

@R0Y15 Added PR for this issue: #114

@krtEngineer
Copy link
Author

krtEngineer commented Oct 19, 2024

@R0Y15 After this PR gets merged I will raise another PRs for using this Netlify function to fetch Weather Data wherever in code Open Weather API is called. A separate PR would be good with separate issue. This is easy for review. Please review this PR #114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants