-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: add qrexec performance tests #647
base: main
Are you sure you want to change the base?
Conversation
I think it would be useful to provide a standalone script that users can run on their own machines, without having to stop qubesd or do something similarly disruptive. The integration tests would then call the script with the appropriate arguments. |
Add simple connection latency, and throughput tests. Run them with different type of services (scripts, socket, via fork-server or not). They print a test run time for comparison - the lower the better. QubesOS/qubes-issues#5740
And what that script would do? Just call call qrexec in a loop? That's oneliner you can simply copy from the test to shell. OTOH, if you'd expect it to create VMs, setup policy etc separately, that would duplicate several parts that our test classes already do (and probably have different bugs while at it). And BTW, creating/removing VMs, adjusting policy etc can be considered "disruptive" too, so it wouldn't even solve your issue. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #647 +/- ##
==========================================
- Coverage 69.78% 69.71% -0.07%
==========================================
Files 58 58
Lines 12499 12499
==========================================
- Hits 8722 8714 -8
- Misses 3777 3785 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Add simple connection latency, and throughput tests. Run them with
different type of services (scripts, socket, via fork-server or not).
They print a test run time for comparison - the lower the better.
QubesOS/qubes-issues#5740
This will be especially useful to measure impact of QubesOS/qubes-core-qrexec#141 and similar changes.