Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add qrexec performance tests #647

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marmarek
Copy link
Member

Add simple connection latency, and throughput tests. Run them with
different type of services (scripts, socket, via fork-server or not).
They print a test run time for comparison - the lower the better.

QubesOS/qubes-issues#5740

This will be especially useful to measure impact of QubesOS/qubes-core-qrexec#141 and similar changes.

@DemiMarie
Copy link
Contributor

I think it would be useful to provide a standalone script that users can run on their own machines, without having to stop qubesd or do something similarly disruptive. The integration tests would then call the script with the appropriate arguments.

Add simple connection latency, and throughput tests. Run them with
different type of services (scripts, socket, via fork-server or not).
They print a test run time for comparison - the lower the better.

QubesOS/qubes-issues#5740
@marmarek
Copy link
Member Author

marmarek commented Jan 21, 2025

And what that script would do? Just call call qrexec in a loop? That's oneliner you can simply copy from the test to shell. OTOH, if you'd expect it to create VMs, setup policy etc separately, that would duplicate several parts that our test classes already do (and probably have different bugs while at it). And BTW, creating/removing VMs, adjusting policy etc can be considered "disruptive" too, so it wouldn't even solve your issue.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.71%. Comparing base (6cd9523) to head (94a3621).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #647      +/-   ##
==========================================
- Coverage   69.78%   69.71%   -0.07%     
==========================================
  Files          58       58              
  Lines       12499    12499              
==========================================
- Hits         8722     8714       -8     
- Misses       3777     3785       +8     
Flag Coverage Δ
unittests 69.71% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qubesos-bot
Copy link

qubesos-bot commented Jan 21, 2025

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025012221-4.3&flavor=pull-requests

Test run included the following:

Installing updates failed, skipping the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants