-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vmupdate: Send SIGUSR1 to meminfo-writer #179
Conversation
The current implementation restart the meminfo-writer service after changing the selinux label which can sometime take a while for the memory to go back to normal. Instead, send a USR1 signal to the meminfo-writer process to change the memory immediately, which also assure smooth selinux updates installation in the future.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
=======================================
Coverage 73.03% 73.03%
=======================================
Files 10 10
Lines 1157 1157
=======================================
Hits 845 845
Misses 312 312 ☔ View full report in Codecov by Sentry. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025012120-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024111705-4.3&flavor=update
Failed tests50 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/119126#dependencies 3 fixed
Unstable tests |
The current implementation restart the meminfo-writer service after changing the selinux label which can sometime take a while for the memory to go back to normal.
Instead, send a USR1 signal to the meminfo-writer process to change the memory immediately, which also assure smooth selinux updates installation in the future.
QubesOS/qubes-issues#9663