Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Shared solution view #376

Merged
merged 1 commit into from
Mar 24, 2024
Merged

fix: Shared solution view #376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lms/templates/view.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,10 +146,10 @@ <h2>{{ _('Comments for this exercise') }}</h2>
</div>
</div>
<script src="{{ url_for('static', filename='prism.js') }}"></script>
{% if not shared_url %}
{% include 'comment-template.html' %}
<script src="{{ url_for('static', filename='purify.js') }}"></script>
<script src="{{ url_for('static', filename='markdown.js') }}"></script>
{% if not shared_url %}
{% include 'comment-template.html' %}
<script src="{{ url_for('static', filename='comments.js') }}"></script>
Comment on lines 150 to 153
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question (code_refinement): Ensure 'markdown.js' is not dependent on 'comment-template.html'.

Given the reordering, confirm that 'markdown.js' does not have any dependencies on 'comment-template.html' being loaded first.

{%- if is_manager or config.USERS_COMMENTS %}
<script src="{{ url_for('static', filename='grader.js') }}"></script>
Expand Down
Loading