fix: Shared solution view #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @yammesicka - I've reviewed your changes and they look great!
General suggestions:
- Verify the dependency chain among the JavaScript files to ensure the reordering does not affect their execution.
- Consider adding a brief comment in the code explaining the reason for the specific ordering of script and template includes, for future maintainability.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Comment on lines
150
to
153
| <script src="{{ url_for('static', filename='markdown.js') }}"></script> | ||
| {% if not shared_url %} | ||
| {% include 'comment-template.html' %} | ||
| <script src="{{ url_for('static', filename='comments.js') }}"></script> |
There was a problem hiding this comment.
question (code_refinement): Ensure 'markdown.js' is not dependent on 'comment-template.html'.
Given the reordering, confirm that 'markdown.js' does not have any dependencies on 'comment-template.html' being loaded first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.