Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update central heat pumps #153

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Update central heat pumps #153

merged 5 commits into from
Nov 11, 2024

Conversation

amos-schledorn
Copy link
Contributor

@amos-schledorn amos-schledorn commented Nov 6, 2024

Closes # (if applicable).

Changes proposed in this Pull Request

  • Geothermal-sourced central heat pumps are split into heat pump and source: investment costs are allocated based on DEA data on this split. I am assuming that O&M costs can be kept unchanged, since they are expressed in relative terms (% per capacity/year or EUR/capacity)
  • Excess-heat sourced heat pumps are added.
  • Water-sourced heat pumps are added. Seawater heat pump data from DEA are used as a proxy.
  • I am using sea-water heat pumps as a basis for water-sourced heat pumps in general. The default DEA data refers to the heat-pump-part only, assuming seawater intake etc. to already exist. They recommend to use the upper data in the upper uncertainty range if this additional equipment is necessary. We follow this recommendation here, which requires some custom indexing and inter-/extrapolation.

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Data source for new technologies is clearly stated.
  • Newly introduced dependencies are added to environment.yaml (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the GPLv3 license.

@amos-schledorn amos-schledorn marked this pull request as draft November 6, 2024 11:35
@amos-schledorn amos-schledorn marked this pull request as ready for review November 8, 2024 16:57
Copy link
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a release note with a warning about the changed coverage of cost of central geothermal-sourced heat pump entry, then it's good to go!

outputs/costs_2020.csv Show resolved Hide resolved
@amos-schledorn amos-schledorn requested a review from fneum November 11, 2024 08:47
@fneum fneum merged commit a1d7ca7 into master Nov 11, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants