Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Sept update 23 into master #838

Merged
merged 129 commits into from
Sep 28, 2023
Merged

Merge Sept update 23 into master #838

merged 129 commits into from
Sep 28, 2023

Commits on Jul 28, 2023

  1. Bump {slfhelper} version

    The new version is needed to read the SLFs now. We use this in `get_existing_data_for_tests()`
    Moohan committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    d9ac7ca View commit details
    Browse the repository at this point in the history
  2. Remove unnecessary code from get_anon_chi (#759)

    * remove unnecessary code from `get_anon_chi`
    
    `get_anon_chi` was updated in slfhelper v0.10
    
    * [check-spelling] Update metadata
    
    Update for https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/5669528966/attempts/1
    Accepted in #759 (comment)
    
    Signed-off-by: check-spelling-bot <[email protected]>
    
    ---------
    
    Signed-off-by: check-spelling-bot <[email protected]>
    Co-authored-by: marjom02 <[email protected]>
    Co-authored-by: Megan McNicol <[email protected]>
    3 people authored Jul 28, 2023
    Configuration menu
    Copy the full SHA
    d731bf7 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Configuration menu
    Copy the full SHA
    1269b3b View commit details
    Browse the repository at this point in the history
  2. Comment out dataset writing targets

    These take a very long time to run, so were skipped at the last update. They need to be revisited.
    Moohan committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    1ea0a1a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    965f05c View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Correct some documentation (#769)

    * Correct some documentation
    
    This resolves a build warning.
    
    * Style code
    
    ---------
    
    Co-authored-by: Moohan <[email protected]>
    Moohan and Moohan authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    d75922a View commit details
    Browse the repository at this point in the history
  2. Make some changes suggested by lintr

    Lots of layout changes, as well as lots of implicit to explicit integer / double changes.
    Moohan committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    5fd538f View commit details
    Browse the repository at this point in the history
  3. Document

    Moohan committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    4c9c175 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6e55e84 View commit details
    Browse the repository at this point in the history
  5. Fix documentation typo

    Moohan committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    9644e0e View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Investigate missing datazone from episode file (#773)

    * Format postcode into `pc7` format
    
    * Style code
    
    * Style code
    
    * Update documentation
    
    * Update comment in R/process_extract_ae.R
    
    * Implement catch-all for PC7 format
    
    ---------
    
    Co-authored-by: Jennit07 <[email protected]>
    Co-authored-by: James McMahon <[email protected]>
    Co-authored-by: Moohan <[email protected]>
    4 people authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    42e461f View commit details
    Browse the repository at this point in the history
  2. Remove some obsolete code (#770)

    * Remove some obsolete code
    
    Renaming and removing some functions.
    
    * Style code
    
    ---------
    
    Co-authored-by: Moohan <[email protected]>
    Co-authored-by: Zihao Li <[email protected]>
    3 people authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    720b20d View commit details
    Browse the repository at this point in the history
  3. Simplify create_hscp_test_flags (#772)

    * Simplify `create_hscp_test_flags`
    
    * Update documentation
    
    * Style code
    
    * simplify `create_hb_test_flags`
    
    * implement hscp test flags into tests
    
    * Simplify `create_demog_test_flags`
    
    ---------
    
    Co-authored-by: James McMahon <[email protected]>
    Co-authored-by: Moohan <[email protected]>
    3 people authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    4a03434 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Rewrite case when statements (#780)

    * updated code from case_when to case_match as it's a bit easier to read
    
    * Style code
    
    * changed some more `case_when` to `case_match`
    
    * Style code
    
    * [check-spelling] Update metadata
    
    Update for https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/5752014211/attempts/1
    Accepted in #780 (comment)
    
    Signed-off-by: check-spelling-bot <[email protected]>
    
    * Add tests for `convert_sending_location_to_lca`
    
    ---------
    
    Signed-off-by: check-spelling-bot <[email protected]>
    Co-authored-by: marjom02 <[email protected]>
    Co-authored-by: SwiftySalmon <[email protected]>
    Co-authored-by: James McMahon <[email protected]>
    4 people authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    f6be11c View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Update R-CMD-check.yaml (#781)

    Co-authored-by: Jennit07 <[email protected]>
    Moohan and Jennit07 authored Aug 4, 2023
    Configuration menu
    Copy the full SHA
    bb3dbd5 View commit details
    Browse the repository at this point in the history
  2. WIP - add sc client tests

    Jennit07 committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    8aba847 View commit details
    Browse the repository at this point in the history
  3. Update documentation

    Jennit07 authored and github-actions[bot] committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    99ab85f View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Configuration menu
    Copy the full SHA
    598d6ad View commit details
    Browse the repository at this point in the history
  2. Update documentation

    Jennit07 committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    0339c4f View commit details
    Browse the repository at this point in the history
  3. Style code

    Jennit07 authored and github-actions[bot] committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    8857e0a View commit details
    Browse the repository at this point in the history
  4. Fix typo

    Moohan authored Aug 7, 2023
    Configuration menu
    Copy the full SHA
    f207b25 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f949576 View commit details
    Browse the repository at this point in the history
  6. Use "" in select instead of .data$,,,

    Also, use `dplyr::last_col()` to more generically specify the range.
    Moohan authored Aug 7, 2023
    Configuration menu
    Copy the full SHA
    4e7b1c5 View commit details
    Browse the repository at this point in the history
  7. Update documentation

    Moohan authored and github-actions[bot] committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    a7243db View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. added solve for hscp names (#789)

    In processed extract variable is called hscp, and in final SLF it's called hscp2018.
    
    Fixed with nested if statement
    
    Co-authored-by: marjom02 <[email protected]>
    SwiftySalmon and marjom02 authored Aug 9, 2023
    Configuration menu
    Copy the full SHA
    04399a4 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. Fix locality (#802)

    Tiny error and a simple fix.
    
    Co-authored-by: Jennit07 <[email protected]>
    Moohan and Jennit07 authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    3820c19 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f15039c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8ea15c0 View commit details
    Browse the repository at this point in the history
  4. Fix CHI duplicates of chi in individual file (#791)

    * fix duplicated matches in chi in sc data.
    
    * Update R/create_individual_file.R
    
    * update on join_sc_client
    
    * Create a test checking if individual files have duplicated chi
    
    * add duplicated chi number to the tests in process_tests_individual_file
    
    ---------
    
    Co-authored-by: lizihao-anu <[email protected]>
    Co-authored-by: James McMahon <[email protected]>
    3 people authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    80799a2 View commit details
    Browse the repository at this point in the history
  5. Update NSU code for new 22/23 cohort (#784)

    Update `check_year_valid` for NSUs
    Jennit07 authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    19779e3 View commit details
    Browse the repository at this point in the history
  6. Amend get_boxi_extract_path function for archiving DN and CMH data (#…

    …785)
    
    * Update `get_boxi_extract_path` for DN/CMH data
    
    * Remove extra function
    
    * [check-spelling] Update metadata
    
    Update for https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/5856792420/attempts/1
    Accepted in #785 (comment)
    
    Signed-off-by: check-spelling-bot <[email protected]>
    
    ---------
    
    Signed-off-by: check-spelling-bot <[email protected]>
    Co-authored-by: Jennit07 <[email protected]>
    Co-authored-by: James McMahon <[email protected]>
    3 people authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    7e3215d View commit details
    Browse the repository at this point in the history
  7. Fix increase in total preventable beddays (#779)

    * further obsolete code change
    
    * fix the preventable_beddays
    
    Co-authored-by: James McMahon <[email protected]>
    
    ---------
    
    Co-authored-by: James McMahon <[email protected]>
    Co-authored-by: Jennit07 <[email protected]>
    3 people authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    612e069 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    184ef65 View commit details
    Browse the repository at this point in the history
  9. Use get_source_extract_path in homelessness (#796)

    This was already set up, just not used for some reason. Note that this will switch from using a `.rds` to `.parquet` (unless you do `get_source_extract_path(year, "Homelessness", ext = "rds")`).
    
    Co-authored-by: Jennit07 <[email protected]>
    Moohan and Jennit07 authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    06c9944 View commit details
    Browse the repository at this point in the history
  10. Correct tests for NSU

    Moohan committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    9a0007a View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. fix warning on := (#797)

    * fix warning on `:=`
    
    * Update R/aggregate_by_chi.R
    
    Co-authored-by: James McMahon <[email protected]>
    
    * Style code
    
    ---------
    
    Co-authored-by: James McMahon <[email protected]>
    Co-authored-by: lizihao-anu <[email protected]>
    3 people authored Aug 15, 2023
    Configuration menu
    Copy the full SHA
    51a0b05 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fc256e7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0f25195 View commit details
    Browse the repository at this point in the history
  4. Use get_source_extract_path in homelessness (#796)

    This was already set up, just not used for some reason. Note that this will switch from using a `.rds` to `.parquet` (unless you do `get_source_extract_path(year, "Homelessness", ext = "rds")`).
    
    Co-authored-by: Jennit07 <[email protected]>
    Moohan and Jennit07 committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    c4a54f8 View commit details
    Browse the repository at this point in the history
  5. Correct tests for NSU

    Moohan committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    e36c97c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a724206 View commit details
    Browse the repository at this point in the history
  7. Update news for September 23 update (#811)

    * Update News for March and June updates
    
    * Update release date
    
    * WIP - update news for Sep update
    
    * Update NEWS.md
    
    Fix some typos / grammar
    
    ---------
    
    Co-authored-by: James McMahon <[email protected]>
    Jennit07 and Moohan authored Aug 15, 2023
    Configuration menu
    Copy the full SHA
    9e2ce2d View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Apply styling

    Jennit07 committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    399a1f0 View commit details
    Browse the repository at this point in the history
  2. Fix issue with case_match types (#810)

    * Fix issue with `case_match` types
    
    It seems that `case_match()` is stricter about types than `case_when()`. See the below code:
    
    ```r
    library(dplyr)
    # Breaks
    mutate(starwars,
      new_height = case_when(
        height == "172" ~ "170"),
      new_height2 = case_match(
        height,
        "172" ~ "170"
      ),
      .after = "height"
    )
    
    # Works
    mutate(starwars,
      new_height = case_when(
          height == "172" ~ "170"),
      new_height2 = case_match(
        height,
        172L ~ "170"
      ),
      .after = "height"
    )
    ```
    
    Since `sending_location` is an integer, the LHS of `case_match` must be numeric. It was slightly incorrect previously but `case_when` let us get away with it!
    
    I also updated and added to the tests.
    
    * Style code
    
    * Style code
    
    ---------
    
    Co-authored-by: Moohan <[email protected]>
    Co-authored-by: Jennit07 <[email protected]>
    Co-authored-by: Jennit07 <[email protected]>
    4 people authored Aug 16, 2023
    Configuration menu
    Copy the full SHA
    311f1c2 View commit details
    Browse the repository at this point in the history
  3. Bug - Outpatients tests failing due to missing HSCP (#816)

    * Update `produce_source_extract_tests`
    
    * Update outpatients tests with hscp_var = FALSE
    
    * Revert "Style code"
    
    This reverts commit 8e73d4a.
    
    * Style code
    
    * simplify code
    
    * Update documentation
    
    * Rename `hscp_var` to `add_hscp_count`
    
    * Update documentation
    
    ---------
    
    Co-authored-by: Jennit07 <[email protected]>
    Co-authored-by: James McMahon <[email protected]>
    Co-authored-by: Moohan <[email protected]>
    4 people authored Aug 16, 2023
    Configuration menu
    Copy the full SHA
    1d9e6e9 View commit details
    Browse the repository at this point in the history
  4. fix read_sc_all_alarms_telecare with incorrect format in period (#814)

    * fix read_sc_all_alarms_telecare with the incorrect format in period
    
    ---------
    
    Co-authored-by: lizihao-anu <[email protected]>
    Co-authored-by: James McMahon <[email protected]>
    3 people authored Aug 16, 2023
    Configuration menu
    Copy the full SHA
    516545c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c609ccf View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    62a4174 View commit details
    Browse the repository at this point in the history
  7. Update year in 99_NSU extract script

    Jennit07 authored and Moohan committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    d310dfd View commit details
    Browse the repository at this point in the history
  8. Update news for September 23 update (#811)

    * Update News for March and June updates
    
    * Update release date
    
    * WIP - update news for Sep update
    
    * Update NEWS.md
    
    Fix some typos / grammar
    
    ---------
    
    Co-authored-by: James McMahon <[email protected]>
    Jennit07 and Moohan committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    51c4a63 View commit details
    Browse the repository at this point in the history
  9. Apply styling

    Jennit07 authored and Moohan committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    ee3943f View commit details
    Browse the repository at this point in the history
  10. Fix issue with case_match types (#810)

    * Fix issue with `case_match` types
    
    It seems that `case_match()` is stricter about types than `case_when()`. See the below code:
    
    ```r
    library(dplyr)
    # Breaks
    mutate(starwars,
      new_height = case_when(
        height == "172" ~ "170"),
      new_height2 = case_match(
        height,
        "172" ~ "170"
      ),
      .after = "height"
    )
    
    # Works
    mutate(starwars,
      new_height = case_when(
          height == "172" ~ "170"),
      new_height2 = case_match(
        height,
        172L ~ "170"
      ),
      .after = "height"
    )
    ```
    
    Since `sending_location` is an integer, the LHS of `case_match` must be numeric. It was slightly incorrect previously but `case_when` let us get away with it!
    
    I also updated and added to the tests.
    
    * Style code
    
    * Style code
    
    ---------
    
    Co-authored-by: Moohan <[email protected]>
    Co-authored-by: Jennit07 <[email protected]>
    Co-authored-by: Jennit07 <[email protected]>
    4 people committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    61283cc View commit details
    Browse the repository at this point in the history
  11. Bug - Outpatients tests failing due to missing HSCP (#816)

    * Update `produce_source_extract_tests`
    
    * Update outpatients tests with hscp_var = FALSE
    
    * Revert "Style code"
    
    This reverts commit 8e73d4a.
    
    * Style code
    
    * simplify code
    
    * Update documentation
    
    * Rename `hscp_var` to `add_hscp_count`
    
    * Update documentation
    
    ---------
    
    Co-authored-by: Jennit07 <[email protected]>
    Co-authored-by: James McMahon <[email protected]>
    Co-authored-by: Moohan <[email protected]>
    4 people committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    c88562c View commit details
    Browse the repository at this point in the history
  12. fix read_sc_all_alarms_telecare with incorrect format in period (#814)

    * fix read_sc_all_alarms_telecare with the incorrect format in period
    
    ---------
    
    Co-authored-by: lizihao-anu <[email protected]>
    Co-authored-by: James McMahon <[email protected]>
    3 people committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    1e06921 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    2c6853c View commit details
    Browse the repository at this point in the history
  14. Rename sheet name

    Co-authored-by: James McMahon <[email protected]>
    Jennit07 and Moohan authored Aug 16, 2023
    Configuration menu
    Copy the full SHA
    e879f7d View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    7f1d259 View commit details
    Browse the repository at this point in the history
  16. fix warning on := (#797)

    * fix warning on `:=`
    
    * Update R/aggregate_by_chi.R
    
    Co-authored-by: James McMahon <[email protected]>
    
    * Style code
    
    ---------
    
    Co-authored-by: James McMahon <[email protected]>
    Co-authored-by: lizihao-anu <[email protected]>
    3 people committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    f6a1eac View commit details
    Browse the repository at this point in the history
  17. Add new function for counting records by sending location (#782)

    * New function `create_sending_location_test_flags`
    Jennit07 authored Aug 16, 2023
    Configuration menu
    Copy the full SHA
    32c10e5 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    2f25ae9 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Configuration menu
    Copy the full SHA
    4fcf101 View commit details
    Browse the repository at this point in the history
  2. Update documentation

    Moohan authored and github-actions[bot] committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    f103e7a View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Configuration menu
    Copy the full SHA
    acccac3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    008b385 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. add homelessness flags to the episode file. (#815)

    * still sorting out conflicts
    
    * Update documentation
    
    * Style code
    
    * # Working code for homelessness flags
    
    - removes applications that have a missing end date in line with the homelessness work
    - `group_by` and `summarise(max)` to deal with people that have more than one application to prevent case duplication
    
    * Update documentation
    
    * Update R/process_lookup_homelessness.R
    
    Co-authored-by: James McMahon <[email protected]>
    
    * Update R/process_lookup_homelessness.R
    
    Co-authored-by: James McMahon <[email protected]>
    
    * Update R/process_lookup_homelessness.R
    
    Co-authored-by: James McMahon <[email protected]>
    
    * Update R/process_lookup_homelessness.R
    
    Co-authored-by: James McMahon <[email protected]>
    
    * Update documentation
    
    * Update R/process_lookup_homelessness.R
    
    Co-authored-by: James McMahon <[email protected]>
    
    * Update R/process_lookup_homelessness.R
    
    Co-authored-by: James McMahon <[email protected]>
    
    * Update documentation
    
    * Style code
    
    * Update R/process_lookup_homelessness.R
    
    Co-authored-by: James McMahon <[email protected]>
    
    * Update R/process_lookup_homelessness.R
    
    Co-authored-by: James McMahon <[email protected]>
    
    * Style code
    
    * Update documentation
    
    * Update R/process_lookup_homelessness.R
    
    Co-authored-by: James McMahon <[email protected]>
    
    * Update R/process_lookup_homelessness.R
    
    Co-authored-by: James McMahon <[email protected]>
    
    * Update R/process_lookup_homelessness.R
    
    Co-authored-by: James McMahon <[email protected]>
    
    * Update documentation
    
    * Style code
    
    * made James' suggested changes and generally tidied up with lintR.
    Replaced `anon_chi` with `chi`
    
    * Style code
    
    * Update documentation
    
    * # Added homelessness flags to episode and individual files, and targets.
    
    finishing off code to add flags to files
    
    * Style code
    
    * Update documentation
    
    * Update R/process_lookup_homelessness.R
    
    Co-authored-by: James McMahon <[email protected]>
    
    * Update R/process_lookup_homelessness.R
    
    Co-authored-by: James McMahon <[email protected]>
    
    * Update documentation
    
    * Style code
    
    * Update R/process_lookup_homelessness.R
    
    Co-authored-by: James McMahon <[email protected]>
    
    * Style code
    
    * Update documentation
    
    * # Updated documentation
    
    added homelessness params to the episode and individual file
    
    ---------
    
    Co-authored-by: marjom02 <[email protected]>
    Co-authored-by: SwiftySalmon <[email protected]>
    Co-authored-by: James McMahon <[email protected]>
    Co-authored-by: Jennit07 <[email protected]>
    5 people authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    b1a9a7b View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Create HRI Variables (#778)

    * New functions to determine Scottish residents and add HRI variables
    
    * Test to check that non-Scottish residents are flagged correctly
    
    * Style code
    
    * use `.default =` instead of `TRUE ~`
    
    * Make doubles specific
    
    * Update documentation
    
    * Pass the `slf_postcode_lookup` as data instead of the path
    
    * Update documentation
    
    * Use Logical `TRUE`
    
    * Remove parameter `chi_variable`
    
    * rename `keep_flag` to `scottish_resident`
    
    ---------
    
    Co-authored-by: shintoLamp <[email protected]>
    Co-authored-by: James McMahon <[email protected]>
    Co-authored-by: Moohan <[email protected]>
    Co-authored-by: Jennit07 <[email protected]>
    Co-authored-by: Jennit07 <[email protected]>
    Co-authored-by: Jennifer Thom <[email protected]>
    7 people authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    e17c21e View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Remove future from the cohorts code (#821)

    Co-authored-by: Jennit07 <[email protected]>
    Moohan and Jennit07 authored Aug 29, 2023
    Configuration menu
    Copy the full SHA
    63ccf01 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. Configuration menu
    Copy the full SHA
    1bf2bb7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ff4d35f View commit details
    Browse the repository at this point in the history
  3. Remove slfhelper::get_chi()

    Takes too long to process tests
    Jennit07 committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    400822e View commit details
    Browse the repository at this point in the history
  4. Remove slfhelper::get_chi

    Jennit07 committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    ea6eaf1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6b73bae View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5028d82 View commit details
    Browse the repository at this point in the history
  7. Update documentation

    Jennit07 authored and github-actions[bot] committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    550c94d View commit details
    Browse the repository at this point in the history
  8. BUG - Fix for the episode file tests (#823)

    The episode file tests were taking far too long to process the tests due
    to `slfhelper::get_chi()`. I have changed the tests to check for
    `anon_chi` instead of `chi`. This will show how many unique `anon_chi`
    we have and how many missing. The only difference from the `chi` checks
    before is that we cant test for `valid chi` using `phs_methods::`. I
    have tested this against 1718 and it is able to produce the tests.
    
    Once this has merged back in we will be able to run targets again as due
    to tests failing this was unable to create the individual file.
    SwiftySalmon authored Sep 1, 2023
    Configuration menu
    Copy the full SHA
    bf5f9b0 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. Configuration menu
    Copy the full SHA
    628da4d View commit details
    Browse the repository at this point in the history
  2. Include hscp2018 in variable list

    This was causing an issue in tests
    Jennit07 committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    d719b9b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2c465b5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    68f6f4d View commit details
    Browse the repository at this point in the history
  5. Revert "BUG - Fix for the episode file tests (#823)"

    This reverts commit bf5f9b0.
    Jennit07 committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    9d1e902 View commit details
    Browse the repository at this point in the history
  6. Revert "Remove rename of hscp - causes mismatched tests"

    This reverts commit 628da4d.
    Jennit07 committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    74d2212 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Update NEWS.md

    Jennit07 authored Sep 5, 2023
    Configuration menu
    Copy the full SHA
    9b18bd4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cb16605 View commit details
    Browse the repository at this point in the history
  3. Update create_individual_file.R (#824)

    * Update create_individual_file.R
    
    * Update documentation
    
    * Style code
    
    ---------
    
    Co-authored-by: lizihao-anu <[email protected]>
    lizihao-anu and lizihao-anu authored Sep 5, 2023
    Configuration menu
    Copy the full SHA
    fbb00e1 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Lizihao anu patch 1 (#825)

    * Update create_individual_file.R
    
    * Update add_hri_variables.R
    
    * Update documentation
    
    * Style code
    
    * move chi variable after `data`
    
    * move `add_hri_variables` up list and add pipe
    
    * Update documentation
    
    ---------
    
    Co-authored-by: lizihao-anu <[email protected]>
    Co-authored-by: Jennifer Thom <[email protected]>
    Co-authored-by: Jennit07 <[email protected]>
    4 people authored Sep 7, 2023
    Configuration menu
    Copy the full SHA
    883605d View commit details
    Browse the repository at this point in the history
  2. Add HRI last

    Jennit07 committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    cea985c View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Configuration menu
    Copy the full SHA
    d950ce5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    17fe86e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ec1e99a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    71d403c View commit details
    Browse the repository at this point in the history
  5. specify chi_variable in hri select list

    This was causing an error
    Jennit07 authored and lizihao-anu committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    6e817b6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8250d60 View commit details
    Browse the repository at this point in the history
  7. Remove dplyr::everything()

    Jennit07 authored and lizihao-anu committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    e9b30e5 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ab5bc37 View commit details
    Browse the repository at this point in the history
  9. Style code

    Jennit07 authored and lizihao-anu committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    0ba7149 View commit details
    Browse the repository at this point in the history
  10. Update documentation

    Jennit07 authored and lizihao-anu committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    53af730 View commit details
    Browse the repository at this point in the history
  11. Include hl1 variables in aggregate

    Jennit07 authored and lizihao-anu committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    562869a View commit details
    Browse the repository at this point in the history
  12. Revert "Include hl1 variables in aggregate"

    This reverts commit 562869a.
    Jennit07 committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    6089cb6 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Fix aggregation_by_chi (#829)

    * test commit push
    
    * Revert "test commit push"
    
    This reverts commit ff51536.
    
    * combine aggregate_by_chi with sc and without sc
    
    * Style code
    
    * Update documentation
    
    ---------
    
    Co-authored-by: lizihao-anu <[email protected]>
    lizihao-anu and lizihao-anu authored Sep 18, 2023
    Configuration menu
    Copy the full SHA
    d304633 View commit details
    Browse the repository at this point in the history
  2. Update NEWS.md

    Jennit07 authored Sep 18, 2023
    Configuration menu
    Copy the full SHA
    b4a3a44 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Configuration menu
    Copy the full SHA
    a47cbb8 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. BUG - Fix episode file tests (#830)

    * add anon chi parameter in `get_existing_data..`
    
    * remove `slfhelper::get_chi()`
    
    * Use `anon_chi` parameter
    
    * declare `anon_chi` tests
    
    * Update documentation
    
    * update documentation
    
    * Style code
    
    * remove hscp count for now
    
    * Update documentation
    
    ---------
    
    Co-authored-by: Jennit07 <[email protected]>
    Jennit07 and Jennit07 authored Sep 20, 2023
    Configuration menu
    Copy the full SHA
    15dde68 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Configuration menu
    Copy the full SHA
    633d430 View commit details
    Browse the repository at this point in the history
  2. Add tests for compute_mid_year_age (#809)

    * Add tests for `compute_mid_year_age`
    
    * Remove redundant code
    
    * Update documentation
    
    ---------
    
    Co-authored-by: Jennit07 <[email protected]>
    Co-authored-by: Jennit07 <[email protected]>
    3 people authored Sep 25, 2023
    Configuration menu
    Copy the full SHA
    53ede24 View commit details
    Browse the repository at this point in the history
  3. Add a new function to set up keyring (#800)

    * Add a new function to set up keyring
    
    I've tested this by deleting my `.Renviron` and deleting my keyring `keyring::keyring_delete("createslf")` and it seems to work. Would be great to have someone with an existing set-up (Jen) test it, and to have someone who doesn't have it set up to test it.
    
    The code looks complicated but I've just tried to catch every scenario, so the process should be smooth and clear (from the user's point of view).
    
    I've also expanded the code relating to the username, which will now hopefully work in more cases.
    
    * [check-spelling] Update metadata
    
    Update for https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/5824423711/attempts/1
    Accepted in #800 (comment)
    
    Signed-off-by: check-spelling-bot <[email protected]>
    
    * Update documentation
    
    ---------
    
    Signed-off-by: check-spelling-bot <[email protected]>
    Co-authored-by: Jennit07 <[email protected]>
    Co-authored-by: Jennit07 <[email protected]>
    3 people authored Sep 25, 2023
    Configuration menu
    Copy the full SHA
    04c2685 View commit details
    Browse the repository at this point in the history
  4. Add additional tests for get_file_path (#808)

    * Add additional tests for `get_file_path`
    
    * Style code
    
    ---------
    
    Co-authored-by: Moohan <[email protected]>
    Co-authored-by: Jennit07 <[email protected]>
    3 people authored Sep 25, 2023
    Configuration menu
    Copy the full SHA
    9652c69 View commit details
    Browse the repository at this point in the history
  5. Rename run_episode_file() -> create_episode_file() (#803)

    * Rename `run_episode_file()` -> `create_episode_file()`
    
    This improves consistency! When speaking to Megan we noted that having the two 'main' functions with different names was needlessly confusing!
    
    * Delete run_targets_tests.R
    
    * Update documentation
    
    ---------
    
    Co-authored-by: Jennit07 <[email protected]>
    Co-authored-by: Jennit07 <[email protected]>
    Co-authored-by: Megan McNicol <[email protected]>
    4 people authored Sep 25, 2023
    Configuration menu
    Copy the full SHA
    bc2e4b3 View commit details
    Browse the repository at this point in the history
  6. Remove incorrect references to rds (#798)

    * Remove incorrect references to rds
    
    Since we (mostly) don't use rds anymore these references are incorrect and potentially confusing.
    
    I've updated lots of documentation to remove the reference to rds.
    
    I've also updated many comments that mentioned rds (these were probably the most confusing).
    
    * Update documentation
    
    ---------
    
    Co-authored-by: Jennit07 <[email protected]>
    Co-authored-by: Megan McNicol <[email protected]>
    3 people authored Sep 25, 2023
    Configuration menu
    Copy the full SHA
    854868e View commit details
    Browse the repository at this point in the history
  7. Make targets and tarchetypes required packages (#799)

    Co-authored-by: Megan McNicol <[email protected]>
    Moohan and SwiftySalmon authored Sep 25, 2023
    Configuration menu
    Copy the full SHA
    ad98c3c View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Update episode file functions to pass data through (#754)

    * Update `read_file` to return an empty tibble if passed the dummy path
    
    This is needed for some other bits, notably NSUs
    
    * Update SPARRA and HHG paths to return dummy if the year is invalid
    
    * Extract all data as a parameter
    
    * Style code
    
    * Update documentation
    
    * Style code
    
    * Update documentation
    
    * rename `run` to `create_episode_file`
    
    * Update documentation
    
    ---------
    
    Co-authored-by: Moohan <[email protected]>
    Co-authored-by: Jennifer Thom <[email protected]>
    Co-authored-by: Jennit07 <[email protected]>
    4 people authored Sep 26, 2023
    Configuration menu
    Copy the full SHA
    a5bc79e View commit details
    Browse the repository at this point in the history
  2. Tests/it extract path (#807)

    * Add additional tests for `check_it_reference()`
    
    * Make the check on the IT reference stricter
    
    * Update documentation
    
    ---------
    
    Co-authored-by: Jennit07 <[email protected]>
    Co-authored-by: Jennit07 <[email protected]>
    3 people authored Sep 26, 2023
    Configuration menu
    Copy the full SHA
    b7ce1b1 View commit details
    Browse the repository at this point in the history
  3. Update workflow to run against the development branch (#795)

    * Make test-coverage.yaml run against development
    
    * Make lint-changed-files.yaml run against development
    
    ---------
    
    Co-authored-by: Jennit07 <[email protected]>
    Moohan and Jennit07 authored Sep 26, 2023
    Configuration menu
    Copy the full SHA
    2f6f25c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e6148a0 View commit details
    Browse the repository at this point in the history
  5. Update create_episode_file

    Jennit07 committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    381c74d View commit details
    Browse the repository at this point in the history
  6. remove run_episode_file

    Jennit07 committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    85416a9 View commit details
    Browse the repository at this point in the history
  7. Update documentation

    Jennit07 committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    6195c78 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2982878 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    978c3f9 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    3292329 View commit details
    Browse the repository at this point in the history
  11. Update documentation

    Jennit07 committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    798a169 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    ce8f84a View commit details
    Browse the repository at this point in the history
  13. Update client tests

    Jennit07 committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    e0e1888 View commit details
    Browse the repository at this point in the history
  14. Update documentation

    Jennit07 authored and github-actions[bot] committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    54f6958 View commit details
    Browse the repository at this point in the history
  15. Style code

    Jennit07 authored and github-actions[bot] committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    c547386 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    648a4da View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    2604303 View commit details
    Browse the repository at this point in the history
  18. Update documentation

    Jennit07 authored and github-actions[bot] committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    55a5c0e View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Add social care client tests (#783)

    Addresses #672 
    
    I've updated the code for social care client lookup. This used to live
    in each year folder, however i have changed this so that the lookups
    live next to the demographic lookup in `/hscdiip/social_care` and supply
    the update month. This is so that we can have a comparison of the sc
    client lookup data at the current quarter vs the previous update.
    SwiftySalmon authored Sep 27, 2023
    Configuration menu
    Copy the full SHA
    9635e0c View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Configuration menu
    Copy the full SHA
    b11c89e View commit details
    Browse the repository at this point in the history