-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Sept update 23 into master #838
Conversation
The new version is needed to read the SLFs now. We use this in `get_existing_data_for_tests()`
* remove unnecessary code from `get_anon_chi` `get_anon_chi` was updated in slfhelper v0.10 * [check-spelling] Update metadata Update for https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/5669528966/attempts/1 Accepted in #759 (comment) Signed-off-by: check-spelling-bot <[email protected]> --------- Signed-off-by: check-spelling-bot <[email protected]> Co-authored-by: marjom02 <[email protected]> Co-authored-by: Megan McNicol <[email protected]>
These take a very long time to run, so were skipped at the last update. They need to be revisited.
* Correct some documentation This resolves a build warning. * Style code --------- Co-authored-by: Moohan <[email protected]>
Lots of layout changes, as well as lots of implicit to explicit integer / double changes.
* Format postcode into `pc7` format * Style code * Style code * Update documentation * Update comment in R/process_extract_ae.R * Implement catch-all for PC7 format --------- Co-authored-by: Jennit07 <[email protected]> Co-authored-by: James McMahon <[email protected]> Co-authored-by: Moohan <[email protected]>
* Remove some obsolete code Renaming and removing some functions. * Style code --------- Co-authored-by: Moohan <[email protected]> Co-authored-by: Zihao Li <[email protected]>
* Simplify `create_hscp_test_flags` * Update documentation * Style code * simplify `create_hb_test_flags` * implement hscp test flags into tests * Simplify `create_demog_test_flags` --------- Co-authored-by: James McMahon <[email protected]> Co-authored-by: Moohan <[email protected]>
* updated code from case_when to case_match as it's a bit easier to read * Style code * changed some more `case_when` to `case_match` * Style code * [check-spelling] Update metadata Update for https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/5752014211/attempts/1 Accepted in #780 (comment) Signed-off-by: check-spelling-bot <[email protected]> * Add tests for `convert_sending_location_to_lca` --------- Signed-off-by: check-spelling-bot <[email protected]> Co-authored-by: marjom02 <[email protected]> Co-authored-by: SwiftySalmon <[email protected]> Co-authored-by: James McMahon <[email protected]>
Co-authored-by: Jennit07 <[email protected]>
Also, use `dplyr::last_col()` to more generically specify the range.
In processed extract variable is called hscp, and in final SLF it's called hscp2018. Fixed with nested if statement Co-authored-by: marjom02 <[email protected]>
Tiny error and a simple fix. Co-authored-by: Jennit07 <[email protected]>
* fix duplicated matches in chi in sc data. * Update R/create_individual_file.R * update on join_sc_client * Create a test checking if individual files have duplicated chi * add duplicated chi number to the tests in process_tests_individual_file --------- Co-authored-by: lizihao-anu <[email protected]> Co-authored-by: James McMahon <[email protected]>
Update `check_year_valid` for NSUs
* Remove incorrect references to rds Since we (mostly) don't use rds anymore these references are incorrect and potentially confusing. I've updated lots of documentation to remove the reference to rds. I've also updated many comments that mentioned rds (these were probably the most confusing). * Update documentation --------- Co-authored-by: Jennit07 <[email protected]> Co-authored-by: Megan McNicol <[email protected]>
Co-authored-by: Megan McNicol <[email protected]>
* Update `read_file` to return an empty tibble if passed the dummy path This is needed for some other bits, notably NSUs * Update SPARRA and HHG paths to return dummy if the year is invalid * Extract all data as a parameter * Style code * Update documentation * Style code * Update documentation * rename `run` to `create_episode_file` * Update documentation --------- Co-authored-by: Moohan <[email protected]> Co-authored-by: Jennifer Thom <[email protected]> Co-authored-by: Jennit07 <[email protected]>
* Add additional tests for `check_it_reference()` * Make the check on the IT reference stricter * Update documentation --------- Co-authored-by: Jennit07 <[email protected]> Co-authored-by: Jennit07 <[email protected]>
* Make test-coverage.yaml run against development * Make lint-changed-files.yaml run against development --------- Co-authored-by: Jennit07 <[email protected]>
Addresses #672 I've updated the code for social care client lookup. This used to live in each year folder, however i have changed this so that the lookups live next to the demographic lookup in `/hscdiip/social_care` and supply the update month. This is so that we can have a comparison of the sc client lookup data at the current quarter vs the previous update.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view or the 📜action log for details. Unrecognized words (55)
To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/6337086641/attempts/1' To have the bot do this for you, reply quoting the following line: Available 📚 dictionaries could cover words not in the 📘 dictionaryThis includes both expected items (235) from .github/actions/spelling/expect.txt and unrecognized words (55)
Consider adding them using (in with:
extra_dictionaries:
cspell:npm/npm.txt
cspell:swift/src/swift.txt
cspell:sql/src/tsql.txt
cspell:python/src/python/python.txt
cspell:python/src/python/python-lib.txt
cspell:python/src/common/extra.txt
cspell:lorem-ipsum/dictionary.txt
cspell:latex/latex.txt
cspell:html/html.txt
cspell:fullstack/fullstack.txt To stop checking additional dictionaries, add: with:
check_extra_dictionaries: '' If the flagged items are 🤯 false positivesIf items relate to a ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks fine
September 23 update is now complete and we are ready to bring the code into master