-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create individual file #715
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
* Drop `cost_total_net_inc_dnas` * Rename `health_net_costincdnas` to `health_net_cost_inc_dnas`
This comment has been minimized.
This comment has been minimized.
* Create function for matching on slf lookups * fix some build warnings * Add `hbrescode` to select list * Pass lookups as parameters/deal with hbrescode * Update R/create_individual_file.R --------- Co-authored-by: James McMahon <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lizihao-anu I don't think we need the zoo package? I assume this was used in some of the 'original code'.
Can you confirm, and also remove aggregate_ch_episodes
and aggregate_by_chi
and rename 'your' data.table versions to take their place as I think we're happy they work and do a better / faster job.
* New function for matching sc client to indiv file * Style code * [check-spelling] Update metadata Update for https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/5555048903/attempts/1 Accepted in #740 (comment) Signed-off-by: check-spelling-bot <[email protected]> * Code layout * Style code * Remove redundant sc variables Co-authored-by: James McMahon <[email protected]> * Update comments Co-authored-by: James McMahon <[email protected]> * Update comments Co-authored-by: James McMahon <[email protected]> * Sort order of parameters to pass `data` first * Update documentation * Style code * Update R/create_individual_file.R * Update R/create_individual_file.R * Update R/create_individual_file.R * Style code --------- Signed-off-by: check-spelling-bot <[email protected]> Co-authored-by: Jennit07 <[email protected]> Co-authored-by: James McMahon <[email protected]> Co-authored-by: Moohan <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
* Make episode file output with `anon_chi` I've added this as a parameter so you can output CHI if desired, but the default is for anon_chi. For the tests, it swaps back to CHI as there are some tests which specifically us the CHI number. * Output `anon_chi` in the individual file * Style code * Sort variables with issues `hbrescode` (HB2018), `datazone` and `hscp` (#746) * rename `hscp` to `hscp2018` * rename `spd` as `slf_pc_lookup` * Add `datazone2011` to coalesce code * Rename `datazone` to `datazone2011` * include `datazone2011_old` in selections * Update R/fill_geographies.R --------- Co-authored-by: James McMahon <[email protected]> * Fix for anon_chi being NA --------- Co-authored-by: Moohan <[email protected]> Co-authored-by: Jennit07 <[email protected]>
This comment has been minimized.
This comment has been minimized.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view or the 📜action log for details. Unrecognized words (9)addmission To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/5598627453/attempts/1' To have the bot do this for you, reply quoting the following line: Available 📚 dictionaries could cover words not in the 📘 dictionaryThis includes both expected items (215) from .github/actions/spelling/expect.txt and unrecognized words (9)
Consider adding them using (in with:
extra_dictionaries:
cspell:sql/src/tsql.txt
cspell:python/src/python/python.txt
cspell:python/src/python/python-lib.txt
cspell:npm/npm.txt
cspell:lorem-ipsum/dictionary.txt
cspell:latex/latex.txt
cspell:html/html.txt
cspell:fullstack/fullstack.txt
cspell:filetypes/filetypes.txt
cspell:elixir/elixir.txt To stop checking additional dictionaries, add: with:
check_extra_dictionaries: '' If the flagged items are 🤯 false positivesIf items relate to a ...
|
No description provided.