Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the Individual File (Jumping Rivers) #561

Closed
wants to merge 117 commits into from
Closed

Create the Individual File (Jumping Rivers) #561

wants to merge 117 commits into from

Conversation

jr-mandy
Copy link
Contributor

@jr-mandy jr-mandy commented Feb 17, 2023

!551 should be reviewed first, as it contains some notes which are relevant for this PR too.

This continues the conversion up until L731, including aggregating the data into a one-row-per-CHI format. The final function in create_individual_file.R (clean_up_postcode()) is still a WIP, and can be removed from this PR if desired.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@shintoLamp
Copy link
Contributor

Need to review the assignment of column names to be in line with R standards

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@Moohan Moohan changed the base branch from main-R to master July 3, 2023 10:35
@Moohan Moohan changed the title Create the Individual File Create the Individual File (Jumping Rivers) Jul 3, 2023
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

@check-spelling-bot Report

🔴 Please review

See the 📂 files view or the 📜action log for details.

Unrecognized words (13)
dfc
gls
jennifer
lgl
Mcbride
mcmahon
newcons
nrs
reabl
rowwise
SLF
vectorised
zihao
To accept ✔️ these unrecognized words as correct and remove the previously acknowledged and now absent words, run the following commands

... in a clone of the [email protected]:Public-Health-Scotland/source-linkage-files.git repository
on the d01_2 branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/main/apply.pl' |
perl - 'https://github.com/Public-Health-Scotland/source-linkage-files/actions/runs/5443510051/attempts/1'

To have the bot do this for you, reply quoting the following line:
@check-spelling-bot apply updates.

Available 📚 dictionaries could cover words not in the 📘 dictionary

This includes both expected items (195) from .github/actions/spelling/expect.txt and unrecognized words (13)

Dictionary Entries Covers
cspell:lorem-ipsum/dictionary.txt 240 1
cspell:latex/latex.txt 424 1

Consider adding them using (in .github/workflows/spelling.yml):

      with:
        extra_dictionaries:
          cspell:lorem-ipsum/dictionary.txt
          cspell:latex/latex.txt

To stop checking additional dictionaries, add:

      with:
        check_extra_dictionaries: ''
If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@Moohan
Copy link
Member

Moohan commented Jul 17, 2023

This branch / PR is now superseded by #715

@Moohan Moohan closed this Jul 17, 2023
@Moohan Moohan deleted the d01_2 branch July 17, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants