Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-16942 | Update Inbound Configuration Accordion Icon in Node Inspector Panel #429

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

mcraeteisha
Copy link
Contributor

@mcraeteisha mcraeteisha commented Jul 9, 2024

Issue

Ticket: FOUR-16942

The RPA Node Inspector Panel introduced a new accordion for Inbound Configuration. To maintain consistency with other accordions, an icon was added alongside its label using the provided icon.

Solution

  • Update the FormAccordion component in vue-form-elements to handle svg icons. (Previously, it only handled Font Awesome Icons.)
  • Add the svg icon to the Inbound Configuration accordion in package-rpa.

How to Test

  1. Go to branch observation/FOUR-16942 in package-rpa and vue-form-elements.
  2. Go to Designer → Processes. Create a Process.
  3. Open the Process in the Modeler.
  4. Add the RPA Node to the Modeler canvas.
  5. Click on the RPA Node. View the RPA Node Inspector Panel.
    • The Inbound Configuration accordion should have an icon. The styling of the icon should be similar to that of the other accordion icons.

ci:next

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

Copy link

@ryancooley ryancooley merged commit 0ff21ae into next Jul 11, 2024
7 checks passed
@ryancooley ryancooley deleted the observation/FOUR-16942 branch July 11, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants