FOUR-17278 Remove temporal files from failing script tasks

ProcessMaker/Models/ScriptDockerBindingFilesTrait.php

@@ -2,7 +2,7 @@
 
 namespace ProcessMaker\Models;
 
-use Log;
+use Illuminate\Support\Facades\Log;
 use ProcessMaker\Exception\ScriptException;
 use ProcessMaker\Exception\ScriptTimeoutException;
 use ProcessMaker\Facades\Docker;
@@ -75,6 +75,7 @@ private function runContainer($image, $command, $parameters, $bindings, $timeout
         if ($returnCode) {
             if ($returnCode == 137 || $returnCode == 9) {
                 Log::error('Script timed out');
+                $this->removeTemporalFiles();
                 throw new ScriptTimeoutException(
                     __('Script took too long to complete. Consider increasing the timeout.')
                   . "\n"
@@ -88,6 +89,7 @@ private function runContainer($image, $command, $parameters, $bindings, $timeout
             $message = implode("\n", $output);
             $message .= "\n\nProcessMaker Stack:\n";
             $message .= (new \Exception)->getTraceAsString();
+            $this->removeTemporalFiles();
             throw new ScriptException($message);
         }
         $outputs = $this->getOutputFilesContent();

upgrades/2024_08_26_220829_remove_old_script_files.php

@@ -0,0 +1,46 @@
+<?php
+
+use ProcessMaker\Upgrades\UpgradeMigration as Upgrade;
+
+class RemoveOldScriptFiles extends Upgrade
+{
+    /**
+     * Run the upgrade migration.
+     *
+     * @return void
+     */
+    public function up()
+    {
+        // Remove old script input files (with prefix `put`)
+        $path = config('app.processmaker_scripts_home');
+        $files = glob($path . '/put*');
+        foreach ($files as $file) {
+            if (is_file($file)) {
+                unlink($file);
+            }
+        }
+
+        // Remove old script files with prefix `get`
+        $path = config('app.processmaker_scripts_home');
+        $files = glob($path . '/get*');
+        $timeNow = time();
+
+        foreach ($files as $file) {
+            // Verify if the file was created 1 hour ago or more
+            if (filemtime($file) <= ($timeNow - 3600)) {
+                unlink($file);
+            }
+        }
+    }
+
+    /**
+     * Reverse the upgrade migration.
+     *
+     * @return void
+     */
+    public function down()
+    {
+        //
+    }
+}
+