Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-17278 Remove temporal files from failing script tasks #7281

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

caleeli
Copy link
Contributor

@caleeli caleeli commented Aug 26, 2024

When a script task fails it keeps the data it uses to run

This cause the disk get filled during the time and when there are lots of scripts failing.

Solution

  • Remove the temporal fails even if script task fails, since the log and data is available in the DB
  • Remove old temporal files

How to Test

  • Update the environment (php artisan upgrade).
  • Check that the config('app.processmaker_scripts_home') folder is empty unless it have pending script for a window of 1 hour.
  • Run an script with an exception. e.g.
<?php 
sleep(5);
throw new Exception("!!");

return [];
  • Check that the config('app.processmaker_scripts_home') folder is empty

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next

@caleeli caleeli changed the base branch from develop to next August 26, 2024 22:57
@ryancooley ryancooley merged commit bc80bc3 into next Sep 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants