Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ModelExporter #24

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Added ModelExporter #24

wants to merge 7 commits into from

Conversation

Nelonn
Copy link

@Nelonn Nelonn commented Jul 20, 2024

No description provided.

@AlexProgrammerDE
Copy link
Contributor

Hi, I see you just added a separate git repositiry inside of this repository. Please PR new files into the existing repository instead of making a brand new repository and new mod.

@AlexProgrammerDE
Copy link
Contributor

This code also only works with 1.21. You need to add a file for every version 1.7-1.21

@extremeheat
Copy link
Member

Multi version implementations would be nice if you have the time to write it but it's not a requirement as it's not required by anything in PrismarineJS at the moment.

@Nelonn
Copy link
Author

Nelonn commented Jul 20, 2024

Hi, I see you just added a separate git repositiry inside of this repository. Please PR new files into the existing repository instead of making a brand new repository and new mod.

I'm on macOS and cannot compile 1.12.2 version, so i added separate project that i can build.

A problem occurred configuring project ':1.12.2'.
> Failed to notify project evaluation listener.
   > Could not resolve all files for configuration ':1.12.2:minecraftLibraries'.
      > Could not find java-objc-bridge-1.0.0-natives-osx.jar (ca.weblite:java-objc-bridge:1.0.0).
        Searched in the following locations:
            https://repo.maven.apache.org/maven2/ca/weblite/java-objc-bridge/1.0.0/java-objc-bridge-1.0.0-natives-osx.jar
   > Could not resolve all files for configuration ':1.12.2:minecraftLibraries'.
      > Could not find java-objc-bridge-1.0.0-natives-osx.jar (ca.weblite:java-objc-bridge:1.0.0).
        Searched in the following locations:
            https://repo.maven.apache.org/maven2/ca/weblite/java-objc-bridge/1.0.0/java-objc-bridge-1.0.0-natives-osx.jar

Possible solution:
 - Declare repository providing the artifact, see the documentation at https://docs.gradle.org/current/userguide/declaring_repositories.html

Also I'm using mojang mappings because we shouldn't be dependent of one technology like fabric (I'm talking about yarn mappings)

@Nelonn
Copy link
Author

Nelonn commented Jul 20, 2024

Multi version implementations would be nice if you have the time to write it but it's not a requirement as it's not required by anything in PrismarineJS at the moment.

Entities don't differ much from version to version and I don't have time to implement this on legacy versions.

@AlexProgrammerDE
Copy link
Contributor

I'm on macOS and cannot compile 1.12.2 version, so i added separate project that i can build.

This commit will fix it: 5757961

Also I'm using mojang mappings because we shouldn't be dependent of one technology like fabric (I'm talking about yarn mappings)

The team uses yarn because it is consistent from 1.7.-1.21. Being despondent on fabric is good here since it helps maintaining the project.

@AlexProgrammerDE
Copy link
Contributor

Entities don't differ much from version to version and I don't have time to implement this on legacy versions.

There are enough differences to warrant a implementation per version. But only for 1.21 should be sufficient as extremeheat said.

@AlexProgrammerDE
Copy link
Contributor

Please add the code to the 1.21 module instead of adding a brand new submodule.

@Nelonn
Copy link
Author

Nelonn commented Jul 21, 2024

I'm on macOS and cannot compile 1.12.2 version, so i added separate project that i can build.

This commit will fix it: 5757961

Also I'm using mojang mappings because we shouldn't be dependent of one technology like fabric (I'm talking about yarn mappings)

The team uses yarn because it is consistent from 1.7.-1.21. Being despondent on fabric is good here since it helps maintaining the project.

Merge your PR then I can work on this PR

UPD: I just compied few lines from build.gradle

@Nelonn
Copy link
Author

Nelonn commented Jul 22, 2024

Another issue on macOS after resetting entire gradle cache:

A problem occurred configuring project ':1.7'.
> Failed to notify project evaluation listener.
   > Could not resolve all files for configuration ':1.7:minecraftLibraries'.
      > Could not resolve org.lwjgl.lwjgl:lwjgl:2.9.1-nightly-20131017.
        Required by:
            project :1.7
         > Could not resolve org.lwjgl.lwjgl:lwjgl:2.9.1-nightly-20131017.
            > Could not parse POM https://libraries.minecraft.net/org/lwjgl/lwjgl/lwjgl/2.9.1-nightly-20131017/lwjgl-2.9.1-nightly-20131017.pom
               > Could not find org.lwjgl.lwjgl:parent:2.9.1-SNAPSHOT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants