Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEAMS3D: Ability to mark self-generated markers with population index #307

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

lazersos
Copy link
Collaborator

This added the capability to use DEX_BEAMS to put each user defined marker in a separate population. Useful for quickly generating heating benchmark plots. If DEX_BEAMS is not specified the code should behave like it always did placing all user generated markers in one population.

@lazersos lazersos added the enhancement New feature or request label Nov 16, 2024
@lazersos lazersos requested a review from kudav November 16, 2024 16:14
@lazersos lazersos self-assigned this Nov 16, 2024
@lazersos lazersos merged commit 34fd1ad into develop Dec 3, 2024
2 checks passed
@lazersos lazersos deleted the feature/BEAMS3D_INPUT_BEAM branch December 3, 2024 07:06
@kudav
Copy link
Collaborator

kudav commented Dec 3, 2024

I think the way it is right now results in some unexpected behavior. I would like to run a slowing-down benchmark with 50 particles with individual pitch values and group these together to have eg individual heating profiles. Loading them in works fine, but using dex_beams is restricted to the first 32 particles:
Running with
DEX_BEAMS = 31*1 2
produces a run with 50 particles, with the first 31 in the first bin and the following particles in the second bin, for which there is no individual control

Running with
DEX_BEAMS = 31*1 2 2
Produces the following error:

----- Input Parameters -----
ERROR reading namelist BEAMS3D_INPUT from file:
input.ORBITS_slow
Invalid line in namelist: DEX_BEAMS = 31*1 2 2

Which does not help to resolve the underlying issue.

My point is, dex_beams for particles fulfills a different purpose (grouping potentially many markers in a few bins) than for the beamlet model (assigning BEAMS3D beams a beamlet index).

@lazersos
Copy link
Collaborator Author

lazersos commented Dec 3, 2024

Just change MAXBEAM=50 for your case and recompile. Restructuring the code would be required at this point and I don't want to do that. This is a simple fix to allow individuals to run an edge case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants