Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with Hummingbird theme #198

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

SharakPL
Copy link
Contributor

@SharakPL SharakPL commented Jan 31, 2024

Questions Answers
Description? Hummingbird theme loads product rating outside thumbnail-container. Selector must consider whole product miniature, not just the product cover where rating is loaded in Classic theme.
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? See PrestaShop/hummingbird#584
How to test? Check visibility in Classic and Hummingbird. PrestaShop/hummingbird#584 needs to be merged first for Hummingbird.

Classic

obraz

Hummingbird

obraz

@florine2623 florine2623 self-assigned this Feb 2, 2024
Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @SharakPL ,

I tested this PR with PrestaShop/hummingbird#584 together.

With classic theme LGTM.

But with hummingbird, the rating from productcomments is missing :

Screen.Recording.2024-02-02.at.10.13.10.mov

Am I missing something ? :)

@SharakPL
Copy link
Contributor Author

SharakPL commented Feb 2, 2024

@florine2623 please check if your product with rating has a layout with classes like this:

obraz

Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @SharakPL ,

I tested with PrestaShop/hummingbird#600
(That PR includes PrestaShop/hummingbird#584)

I have the following :

Screenshot 2024-03-06 at 10 00 13

It is missing has-reviews and reviews-loaded.

Here's my product :

Screen.Recording.2024-03-06.at.10.01.04.mov

Thanks!

@florine2623
Copy link
Contributor

@PrestaShop/qa-functional , I need your help on that, I can't reproduce it on my end 😞

Copy link

@AureRita AureRita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SharakPL

Thank you for your PR, I tested it and it seems to works as you can see :

image

Tested on develop and 8.1.x

Because the PR seems to works as expected, It's QA ✔️

Thank you

@SharakPL SharakPL added this to the 6.0.3 milestone Mar 11, 2024
@SharakPL SharakPL merged commit 3fe4fad into PrestaShop:dev Mar 11, 2024
8 checks passed
@SharakPL SharakPL deleted the fix-compatibility-with-themes branch March 11, 2024 12:01
@florine2623 florine2623 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants