Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 6.0.3 #203

Merged
merged 47 commits into from
Apr 4, 2024
Merged

Release 6.0.3 #203

merged 47 commits into from
Apr 4, 2024

Conversation

boherm
Copy link
Member

@boherm boherm commented Mar 27, 2024

Questions Answers
Description? Release 6.0.3
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket?
How to test?

leemyongpakvn and others added 30 commits June 27, 2022 09:30
install.sql in root directory of module prior v5.0.1 CREATE TABLE with deprecated CHARSET=utf8. It need to be fixed in the upgrade of next version.
@kpodemski Nearly perfect. 👍 When run directly in phpMyAdmin: my code only upgrade table collation, your code upgrade both table and its fields collation.
The remaining issue is Upgrade via BO interface does not call install-**5.0.3**.php. BO upgrade suggest upgrade v5.0.2 -> v5.0.2, and I guess it called  install-**5.0.2**.php instead :(

Co-authored-by: Krystian Podemski <[email protected]>
Fix deprecated CHARSET utf8 in install and upgrade
Fix removing previous module files in PHPStan tests
…since-v400n600

Mark deprecated functions since v4.0.0 and v6.0.0
Co-authored-by: Nicolas Lœuillet <[email protected]>
If user mistakenly attempts to delete a comment, fail gracefully
Remove unneeded version check
@boherm boherm added this to the 6.0.3 milestone Mar 27, 2024
@boherm boherm mentioned this pull request Mar 27, 2024
Copy link
Contributor

@Hlavtox Hlavtox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now all good. :-)))

Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @boherm ,

Upgrade to v6.0.3 went well.
Configuration of module is broken when Debug mode is enabled.

Screenshot 2024-04-02 at 17 05 53
Screen.Recording.2024-04-02.at.17.01.48.mov

Could you check ?

@leemyongpakva
Copy link
Contributor

@florine2623 I think it is a well-known issue, old SF configs in var/cache does not contain newly added service. You can solve it by applying BO > Performance > Clear Cache via Web browser, or running rm -rf /var/cache via Terminal.

Copy link
Contributor

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @boherm ,

Tested the following :
#144
#190
#191
#193
#197
#198

LGTM ✅
Thanks!

@leemyongpakva leemyongpakva merged commit d47e744 into master Apr 4, 2024
16 checks passed
@leemyongpakva
Copy link
Contributor

Thanks @boherm and @florine2623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

10 participants