Update theme.yml - better framework value #651
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matks
commented
Aug 28, 2024
matks
commented
| Questions | Answers |
|---|---|
| Description? | Update theme.yml - better framework value. See discussion here |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes #581 |
| Sponsor company | |
| How to test? |
This was referenced Aug 28, 2024
nicosomb
approved these changes
Aug 29, 2024
jolelievre
requested changes
Aug 29, 2024
There was a problem hiding this comment.
As explained in this comment #649 (comment)
We can simply check a version using semver methods, so having the full version is only a plus I don't see why we wouldn't benefit from it
It doesn't mean all themes will respect this, maybe they will only add the minor version but it doesn't mean we can't use the full version
|
Following @jolelievre comment closing ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.