Add meta framework into theme

[matks]

Questions	Answers
Description?	Add meta framework into theme to allow module developers to find out what framework is used. See similar PR for Classic PrestaShop/classic-theme#149
Type?	new feature
BC breaks?	no
Deprecations?	no
Fixed ticket?	Fixes partially #581
Sponsor company
How to test?

[Hlavtox]

I overlooked it in the second PR, do we want to put it into compatibility section? Isn't it more an general info about the theme?

[kpodemski]

Maybe we could be less specific and use "bootstrap-v5.2" or even "bootstrap-v5", just not to force devs to update every time we update Bootstrap version, my understanding is that they do follow SemVer, so we should be safe.

[jolelievre]

Thanks @matks

[ps-jarvis]

PR merged, well done!

Message to @PrestaShop/committers: do not forget to milestone it before the merge.

[kpodemski]

I'm blocking this PR since we need to be careful not to integrate this flag incorrectly.

It's crucial to have an easy way for devs to know that the theme base on the more modern version of bootstrap, but having to do checks like:

if (v = bootstrap-v5.2 || v = bootstrap-v5.3) would not be efficient, unless we will provide some abstraction layer over this flag, so we can easily parse this:

if (framework.name == bootstrap and framework.version.major == 5)

[kpodemski]

oh no @jolelievre 😅

[matks]

@kpodemski Don't worry 😄 this is just a merged PR, not a "final act"

• code can evolve
• in the last resort, PRs can be reverted

I personally don't have a strong opinion on the content of that property, so every option is OK for me 👍

[jolelievre]

Hi @kpodemski

yeah I merged this early because I needed both themes to have the extra configuration to handle the specific modal, but we can always improve those two values before the next release don't worry.

I think having bootstrap-v5.2 is better, I would even go further and integrate the patch version bootstrap-v5.2.5 for example, the reason is because we can use semver comparison method to check this data.

If you look at this PR PrestaShop/PrestaShop#36731 you can see I'm using some JS method to check the version so there's no need to split the version into major/minor/patch It's easier and more accurate to compare the whole version with semver rules like satisfies(frameworkVersion, '^4.0.0')

You can look into the JS library small docs here https://www.npmjs.com/package/compare-versions to see how more versatile it can be (1.2.7 || >=1.2.9 <2.0.0, ^10.0.0, ...).

And if you think we also need this kind of comparison in twig and/or smarty I think we can add some functions to allow similar tests

[kpodemski]

@jolelievre

And if you think we also need this kind of comparison in twig and/or smarty I think we can add some functions to allow similar tests

Yes, that would be great. Ultimately, we should be able to do such comparisons on the controller and view level.

[jolelievre]

@kpodemski we already have this kind of tools in PHP thanks to composer https://github.com/composer/semver/blob/main/src/Semver.php#L32

We'd just need to add a twig and smarty functions to use it in the view

[kpodemski]

@jolelievre ok, I thought we'd like to wrap it, so that we don't rely on composer's code directly 👍🏻

[matks]

Hi @kpodemski

yeah I merged this early because I needed both themes to have the extra configuration to handle the specific modal, but we can always improve those two values before the next release don't worry.

I think having bootstrap-v5.2 is better, I would even go further and integrate the patch version bootstrap-v5.2.5 for example, the reason is because we can use semver comparison method to check this data.

If you look at this PR PrestaShop/PrestaShop#36731 you can see I'm using some JS method to check the version so there's no need to split the version into major/minor/patch It's easier and more accurate to compare the whole version with semver rules like satisfies(frameworkVersion, '^4.0.0')

You can look into the JS library small docs here https://www.npmjs.com/package/compare-versions to see how more versatile it can be (1.2.7 || >=1.2.9 <2.0.0, ^10.0.0, ...).

And if you think we also need this kind of comparison in twig and/or smarty I think we can add some functions to allow similar tests

New PRs for themes

• Update theme.yml - better framework value #651
• Update theme.yml - better framework value classic-theme#150

[jolelievre]

@matks I don't know if you read my comment, but I don't understand the interest of your PRs?
We have tools that allow checking, comparing versions efficiently and very, so why not give as much detail as possible? 🤔