Passage to level 6 of PHPstan verifications, various fixes and removal of unused variables and functions #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
M0rgan01
commented
Jun 17, 2024
•
M0rgan01
commented
| Questions | Answers |
|---|---|
| Description? | Passage to level 6 of PHPstan verifications, various fixes and removal of unused variables and functions |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | - |
| Sponsor company | - |
| How to test? | Module should works the same as before |
M0rgan01
force-pushed
the
adding-typing
branch
5 times, most recently
from
fb77d6b to
578ae30
Compare
M0rgan01
force-pushed
the
adding-typing
branch
8 times, most recently
from
e5cdd6f to
69990f7
Compare
Quetzacoalt91
previously approved these changes
Jun 24, 2024
matks
reviewed
Jun 25, 2024
| /** | ||
| * @var string contains hte url where to download the file | ||
| * @var string contains the url to download the file |
| * @param string $string Error message | ||
| * @param bool $htmlentities By default at true for parsing error message with htmlentities | ||
| */ | ||
| public static function displayError(string $string = 'Fatal error', bool $htmlentities = true): string |
There was a problem hiding this comment.
Even though modules are not subject to same SemVer constraints as the core because they are not supposed to be decorated, this is a little out of the scope of the PR
Two suggestions:
- Remove this and make this PR "only about PHPStan typing"
- Keep this but update the PR description 😉 and title
M0rgan01
changed the title
Quetzacoalt91
previously approved these changes
Jun 25, 2024
Quetzacoalt91
previously approved these changes
Jul 2, 2024
M0rgan01
force-pushed
the
adding-typing
branch
4 times, most recently
from
973c591 to
ef823ab
Compare
Quetzacoalt91
previously approved these changes
Jul 3, 2024
Quetzacoalt91
approved these changes
Jul 4, 2024
AureRita
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Hi @M0rgan01
Thank you for your PR, I tested it and it seems to works as expectd
Tested from :
1.7.8.9 to 1.7.8.11
1.7.8.9 to 8.1.7
8.0.5 to 8.1.7
8.1.5 to 8.1.7
8.1.7 to 9.0.0
8.1.5 to 9.0.0
8.0.5 to 9.0.0
Because the PR seems to works as expected, It's QA ✔️
Thank you
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.