-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return exit code on unhandled exceptions, and allow process to go on when upgrading a module fails #752
Conversation
The workflow
|
d10d26d
to
0d1b1c8
Compare
832f108
to
82dcbdb
Compare
c06f2a1
to
2171383
Compare
2171383
to
6556060
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR, I tested it and it seems to works as you can see :
Tested from :
1.7.6.4 to 8.1.7
8.0.5 to 8.1.7
8.1.5 to 8.1.7
8.1.7 to 9.0.0
8.1.5 to 9.0.0
8.0.5 to 9.0.0
Because the PR seems to works as expected, It's QA ✔️
FYI : When you baddly change the "_construct" of a module, you still have an exception as you can see :
(seen with @Quetzacoalt91 )
Thank you
6556060
to
8b7fb17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️ Waiting for #727 to be merged first
PR contents: