Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only take scheduled full snapshots #1285

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

pauldambra
Copy link
Member

We currently take a full snapshot when

(in order of increasing frequency)

  • rrweb starts
  • when the session id or window id changes
  • when returning from idle
  • on a timer
  • when we see a $pageview event

we also infrequently see reports that playback is inconsistent around $pageviews

let's not take that speculative snapshot

Copy link

vercel bot commented Jul 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Jul 4, 2024 8:49am

@pauldambra pauldambra added the bump patch Bump patch version when this PR gets merged label Jul 4, 2024
@pauldambra pauldambra requested a review from daibhin July 4, 2024 08:32
Copy link

github-actions bot commented Jul 4, 2024

Size Change: -100 B (-0.01%)

Total Size: 1.15 MB

Filename Size Change
dist/array.full.js 317 kB -25 B (-0.01%)
dist/array.js 154 kB -25 B (-0.02%)
dist/main.js 155 kB -25 B (-0.02%)
dist/module.js 154 kB -25 B (-0.02%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 10.4 kB
dist/recorder-v2.js 110 kB
dist/recorder.js 110 kB
dist/surveys-preview.js 60.3 kB
dist/surveys.js 65.4 kB
dist/tracing-headers.js 8.26 kB
dist/web-vitals.js 5.79 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants