Skip to content

Commit

Permalink
fix: only take scheduled full snapshots (#1285)
Browse files Browse the repository at this point in the history
  • Loading branch information
pauldambra authored Jul 4, 2024
1 parent 430630e commit b1e292d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion cypress/e2e/error-tracking.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ describe('Exception autocapture', () => {
cy.get('[data-cy-button-throws-error]').click()

// ugh
cy.wait(500)
cy.wait(1500)

cy.phCaptures({ full: true }).then((captures) => {
expect(captures.map((c) => c.event)).to.deep.equal(['$pageview', '$autocapture', '$exception'])
Expand Down
1 change: 0 additions & 1 deletion src/extensions/replay/sessionrecording.ts
Original file line number Diff line number Diff line change
Expand Up @@ -679,7 +679,6 @@ export class SessionRecording {
return
}
this._tryAddCustomEvent('$pageview', { href })
this._tryTakeFullSnapshot()
}
} catch (e) {
logger.error('Could not add $pageview to rrweb session', e)
Expand Down

0 comments on commit b1e292d

Please sign in to comment.