Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes exception UninitializedStaticallyTypedParameterException when declaring a parameter without default value #27

Open
wants to merge 3 commits into
base: ros2
Choose a base branch
from
Open

Fixes exception UninitializedStaticallyTypedParameterException when declaring a parameter without default value #27

wants to merge 3 commits into from

Conversation

JafarAbdi
Copy link
Contributor

AndyZe
AndyZe reviewed May 25, 2022
View reviewed changes
Copy link

@AndyZe AndyZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait on somebody else to approve this one. It seems like a lot of added code just to fix a nitpicky compiler warning, if I understand right.

@JafarAbdi
Copy link
Contributor Author

I'll wait on somebody else to approve this one. It seems like a lot of added code just to fix a nitpicky compiler warning, if I understand right.

It's an exception not a warning, I updated the title

@JafarAbdi JafarAbdi changed the title Fixes UninitializedStaticallyTypedParameterException when declaring a parameter without default value Fixes exception UninitializedStaticallyTypedParameterException when declaring a parameter without default value May 25, 2022
@JafarAbdi JafarAbdi mentioned this pull request May 25, 2022
Merged
stephanie-eng
stephanie-eng approved these changes May 25, 2022
View reviewed changes
Copy link

@stephanie-eng stephanie-eng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this with moveit/moveit_task_constructor#365, and this solves the UninitializedStaticallyTypedParameterException error that prevented the demo from working

vatanaksoytezer
vatanaksoytezer approved these changes May 25, 2022
View reviewed changes
Copy link

@vatanaksoytezer vatanaksoytezer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, had a similar problem in another project and couldn't come up with something better than this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyZe AndyZe AndyZe left review comments

@vatanaksoytezer vatanaksoytezer vatanaksoytezer approved these changes

@stephanie-eng stephanie-eng stephanie-eng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JafarAbdi @stephanie-eng @AndyZe @vatanaksoytezer