Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MNIInfant to template enum #824

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Add MNIInfant to template enum #824

merged 1 commit into from
Oct 11, 2024

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Oct 9, 2024

Should help with #823.

Changes proposed in this pull request

  • Add MNIInfant to allowed values for SubjectSummary's template input.
  • Remove some unused constants related to templates.

@tsalo tsalo requested a review from mattcieslak October 9, 2024 21:19
@tsalo tsalo added the bug Something isn't working label Oct 9, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.12%. Comparing base (8802df4) to head (4f75cf6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #824      +/-   ##
==========================================
- Coverage   28.12%   28.12%   -0.01%     
==========================================
  Files          69       69              
  Lines       10079    10077       -2     
  Branches     1302     1107     -195     
==========================================
- Hits         2835     2834       -1     
+ Misses       7146     7145       -1     
  Partials       98       98              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mattcieslak mattcieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deletions were just unused variables, thank you!

@mattcieslak mattcieslak merged commit 2967323 into master Oct 11, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants