Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only unmarshal unapproved events in gravity migration #574

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Only unmarshal unapproved events in gravity migration #574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion module/x/gravity/keeper/migrations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,17 @@ func (m Migrator) DeletePendingEventVoteRecords(ctx sdk.Context) error {
var lowestNonce uint64
var unapprovedEventSigners []string
m.keeper.IterateEthereumEventVoteRecords(ctx, func(key []byte, eventVoteRecord *types.EthereumEventVoteRecord) bool {
// Skip approved events
if eventVoteRecord.Accepted {
return false
}

event, err := types.UnpackEvent(eventVoteRecord.Event)
if err != nil {
panic(err)
}
if !eventVoteRecord.Accepted && event.GetEventNonce() > lastObservedEventNonce {

if event.GetEventNonce() > lastObservedEventNonce {
v5Hash := OldHash(event)
ctx.Logger().Info("gravity: v5 event hash: ", v5Hash)
ctx.Logger().Info("gravity: v6 event hash: ", event.Hash())
Expand Down
Loading