Lift SyncFlowWorkflow into activity entirely #2371
Merged
+136
−294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
commented
Dec 17, 2024
serprex
commented
Dec 17, 2024
| @@ -554,12 +546,6 @@ func CDCFlowWorkflow( | |||
|
|
|||
| if shared.ShouldWorkflowContinueAsNew(ctx) { | |||
| restart = true | |||
| if syncFlowFuture != nil { | |||
| if err := model.SyncStopSignal.SignalChildWorkflow(ctx, syncFlowFuture, struct{}{}).Get(ctx, nil); err != nil { | |||
There was a problem hiding this comment.
Have to decide whether cdc_flow restarts hard pause sync flow, otherwise have to setup a whole session state thing so workflow can signal activity to shutdown
serprex
force-pushed
the
sync-flow-activity
branch
6 times, most recently
from
249fc44 to
deac49b
Compare
serprex
force-pushed
the
sync-flow-activity
branch
from
deac49b to
0c551fb
Compare
serprex
force-pushed
the
sync-flow-activity
branch
2 times, most recently
from
b5b8c97 to
cdb3f8f
Compare
|
tested StartToCloseTimeout being hit (1 year in this PR). Result is activity retries. So that's fine |
serprex
force-pushed
the
sync-flow-activity
branch
3 times, most recently
from
d4f9da2 to
a16e168
Compare
serprex
added a commit
that referenced
this pull request
Dec 23, 2024
important once #2371 prevents seeing batch history in temporal
serprex
force-pushed
the
sync-flow-activity
branch
2 times, most recently
from
d22fc5d to
75c035a
Compare
heavycrystal
approved these changes
Dec 24, 2024
|
code looks fine, but need extensive testing due to niche cases |
allowing frequent sync batch frequency without need to reconect
serprex
force-pushed
the
sync-flow-activity
branch
2 times, most recently
from
467fd28 to
85dbc04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.