gauges for current batch id & normalized batch id #2378
Conversation
| @@ -349,6 +349,16 @@ func syncCore[TPull connectors.CDCPullConnectorCore, TSync connectors.CDCSyncCon | |||
| activity.RecordHeartbeat(ctx, pushedRecordsWithCount) | |||
| a.Alerter.LogFlowInfo(ctx, flowName, pushedRecordsWithCount) | |||
|
|
|||
| if a.OtelManager != nil { | |||
| currentBatchID, err := a.OtelManager.GetOrInitInt64Gauge( | |||
There was a problem hiding this comment.
ideally we'd have something like I have for typed temoral slots & then this could just be
otel_metrics.CurrentBatchId.Record(ctx, a.OtelManager, res.CurrentSyncBatchID)
|
need to ensure #2382 doesn't happen with these |
There was a problem hiding this comment.
@serprex if you have bandwidth can you add a couple of metrics more from #2341?
Also as @heavycrystal mentioned, would be great if you could check #2382 while you're at it?
| IntervalSinceLastNormalizeGaugeName string = "interval_since_last_normalize" | ||
| FetchedBytesCounterName string = "fetched_bytes" | ||
| SlotLagGaugeName = "cdc_slot_lag" | ||
| CurrentBatchIdGaugeName = "current_batch_id" |
There was a problem hiding this comment.
Maybe we should call it sync_batch_id
Also wondering if we should emit this twice, one at start and one at end, can attach different labels for both the times.
those would be separate PRs |
important once #2371 prevents seeing batch history in temporal