Fix GO term recommendations #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Dec 15, 2023
Make the size of terms more accurate by calculating only the number of distinct genes among its descendants and itself. Fix a bug in the recommendation that was caused by a term appearing in its own set of descendants and thus being filtering out. Remove the minSize argument, we now only recommend term that have at least one novel gene. Apply the gene size limit when saving a profile by ignoring terms that exceed the limit. Combine genes and TIER3 genes to account for removed genes in an unsaved profile Fix all broken recommendation tests. Make the minimum overlap configurable
arteymix
force-pushed
the
fix-go-term-recommendations
branch
from
21e7b77
to
c5f18e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.