-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug flushing Data frames from asyncio client #56
Conversation
abfaa31
to
96d6fb0
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #56 +/- ##
==========================================
+ Coverage 96.37% 96.41% +0.03%
==========================================
Files 12 12
Lines 1160 1198 +38
==========================================
+ Hits 1118 1155 +37
- Misses 42 43 +1
☔ View full report in Codecov by Sentry. |
When AsyncioClient.data() was called with non-zero flush_period then it only yielded the Data after flush when a new packet of data appeared on the wire or at the end of acquisition. This changes it to be more eager and yield as soon as it is flushed.
96d6fb0
to
f7a5731
Compare
@coretl I just tested the code with PandABox and PandA IOC. Panda was configured to generate 12 trigger pulses, which resulted in 12 data points saved to HDF5 file. So this seems to fix the original issue. But now I see the following error message (IOC remains functional):
|
@dmgav does this work for you now? Should I merge? |
Yes, position capture works now without issues. |
When AsyncioClient.data() was called with non-zero flush_period then it only yielded the Data after flush when a new packet of data appeared on the wire or at the end of acquisition. This changes it to be more eager and yield as soon as it is flushed.