Fix delayed data frame updates #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During data streaming, the pending stage is removed, so that clients gets `FrameData` as soon as possible. A disadvantage is that the client may receive some corrupt data. The user is able to detect this condition, so the benefit is thought to outweigh the disadvantage. When writing HDF5 files via `write_hdf_files`, an exception will now be raised if an overrun occurs. Documentation and tests updated accordingly. Closes PandABlocks#54
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #55 +/- ##
=======================================
Coverage 96.37% 96.37%
=======================================
Files 12 12
Lines 1159 1160 +1
=======================================
+ Hits 1117 1118 +1
Misses 42 42
☔ View full report in Codecov by Sentry. |
|
Excellent, thank you! |
|
Thanks for the review @coretl. Any chance we can get a new release soon? There are a few useful features for us that have been merged. |
|
Sure, I'm just getting #56 ready (which may interest you if you are using the asyncio client with |
|
0.5.1 has been released (thanks @evalott100!) |
|
Thanks @coretl and @evalott100 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During data streaming, the "pending" stage is removed, so that clients gets
FrameDataas soon as possible. A disadvantage is that the client may receive some corrupt data. The user is able to detect this condition, so the benefit is thought to outweigh the disadvantage.API changes:
write_hdf_files, an exception will now be raised if there's an overrun.pandablocks hdfwill have exit code 1 (instead of 0) if there's an overrun.Documentation and tests updated accordingly.
Closes #54